From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <derodat@adacore.com>
Received: from rock.gnat.com (rock.gnat.com
 [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1])
 by sourceware.org (Postfix) with ESMTP id 8F500396AC0F
 for <gcc-patches@gcc.gnu.org>; Tue,  4 May 2021 09:52:26 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8F500396AC0F
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=adacore.com
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=derodat@adacore.com
Received: from localhost (localhost.localdomain [127.0.0.1])
 by filtered-rock.gnat.com (Postfix) with ESMTP id 492855613E;
 Tue,  4 May 2021 05:52:23 -0400 (EDT)
X-Virus-Scanned: Debian amavisd-new at gnat.com
Received: from rock.gnat.com ([127.0.0.1])
 by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id 0OxNhgYAUuUx; Tue,  4 May 2021 05:52:23 -0400 (EDT)
Received: from tron.gnat.com (tron.gnat.com
 [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294])
 by rock.gnat.com (Postfix) with ESMTP id 2B59756132;
 Tue,  4 May 2021 05:52:23 -0400 (EDT)
Received: by tron.gnat.com (Postfix, from userid 4862)
 id 2A91216E; Tue,  4 May 2021 05:52:23 -0400 (EDT)
Date: Tue, 4 May 2021 05:52:23 -0400
From: Pierre-Marie de Rodat <derodat@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Piotr Trojanek <trojanek@adacore.com>
Subject: [Ada] Use function and not procedure UI_Image in pretty-printing
Message-ID: <20210504095223.GA90568@adacore.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="zYM0uCDKw75PZbzx"
Content-Disposition: inline
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 04 May 2021 09:52:28 -0000


--zYM0uCDKw75PZbzx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Code cleanup; semantics is unaffected. The code for pretty-printing
integer, real and string literals now looks the same.

Tested on x86_64-pc-linux-gnu, committed on trunk

gcc/ada/

	* pprint.adb (Expr_Name): Simplify with functional variant of
	UI_Image.
--zYM0uCDKw75PZbzx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="patch.diff"

diff --git a/gcc/ada/pprint.adb b/gcc/ada/pprint.adb
--- a/gcc/ada/pprint.adb
+++ b/gcc/ada/pprint.adb
@@ -226,8 +226,7 @@ package body Pprint is
                end;
 
             when N_Integer_Literal =>
-               UI_Image (Intval (Expr));
-               return UI_Image_Buffer (1 .. UI_Image_Length);
+               return UI_Image (Intval (Expr));
 
             when N_Real_Literal =>
                return Real_Image (Realval (Expr));



--zYM0uCDKw75PZbzx--