From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 2B41C3848400 for ; Wed, 5 May 2021 00:18:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2B41C3848400 Received: by mail-pg1-x52c.google.com with SMTP id s22so512459pgk.6 for ; Tue, 04 May 2021 17:18:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=9hOKwDHXVXA2/pDKjD3l68DX+EVomK1OD4lEAa94TXc=; b=Y2mLM6RXBTOxTyRdTZQOa+zCx6IL/fMOu6kacXjmNeJcsfdBWMIURZWaBYi2O65xGt QITb05pMmKb5YZAAWOipJTDN7OaqqqXxhNit4vfdcGkFFG5/Sj3wo72tWhL3L8LTzSDk TYvxU4Fz1zse+/J1+DwEte5bdxg5VeisIyq+U03kA+eFT5yg3b6YguNYwWhKRZmwi5j1 Fn5sJZZs0GGwmaeXSg+9PlleGSq61wSkZ0RFPLX8ykz25BP4lISbkiy6N7wJT9oh7meG Tb6CUHYc6m8HP5AhwImEsWTYHaiV8jjBUgn2xABLRCuivJg1XpfnxzrG9fT4I2w1F4qA gUlQ== X-Gm-Message-State: AOAM5301XG+yfxZDZm2bEIPqKH6tcszT7SQ1pCxdFHyJ/+mfe5KUkVXp dLzBWUibnoUomNUX/pkUqJu3W4HbWiDDOA== X-Google-Smtp-Source: ABdhPJypUqF7DU+/Pd0X/viVmNY2E4QHHOdqH3ooPhlWV3UKHcL36WrMKhHd8cHiSKo9XHfmKZQpKA== X-Received: by 2002:a17:90a:d98b:: with SMTP id d11mr6938171pjv.33.1620173910866; Tue, 04 May 2021 17:18:30 -0700 (PDT) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id x11sm15098374pjr.21.2021.05.04.17.18.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 May 2021 17:18:29 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id A792941A04; Wed, 5 May 2021 09:48:25 +0930 (ACST) Date: Wed, 5 May 2021 09:48:25 +0930 From: Alan Modra To: Nick Clifton , gcc-patches@gcc.gnu.org, "H.J. Lu" Subject: Re: RFC: Changing AC_PROG_CC to AC_PROG_CC_C99 in top level configure Message-ID: <20210505001825.GN22624@bubble.grove.modra.org> References: <8c1b0ed9-e6f3-9c22-45c5-c2680a2a4830@polymtl.ca> <3e562764-ce93-d4a2-fbba-dc622c9b5bb7@redhat.com> <3c76d8a1-d029-237d-054c-0ff65eb063cb@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3c76d8a1-d029-237d-054c-0ff65eb063cb@polymtl.ca> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-3040.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 May 2021 00:18:40 -0000 On 2021-05-04 8:42 a.m., Nick Clifton wrote: > Hi Guys, > > On 4/30/21 7:36 PM, Simon Marchi wrote: >> I think this fix is obvious enough, I encourage you to push it, > > OK - I have pushed the patch to the mainline branches of both > the gcc and binutils-gdb repositories. Thanks Nick! Incidentally, I checked the AC_PROG_CC_C99 change on both binutils and gcc mainline using gcc-4.9. To build gcc on x86_64 I found the following patch necessary to avoid lots of error: uninitialized const member ‘stringop_algs::stringop_strategy::max’ error: uninitialized const member ‘stringop_algs::stringop_strategy::alg’ when compiling config/i386/i386-options.c. These can't be cured by configuring with --disable-stage1-checking. diff --git a/gcc/config/i386/i386.h b/gcc/config/i386/i386.h index 97d6f3863cb..cc3b1b6d666 100644 --- a/gcc/config/i386/i386.h +++ b/gcc/config/i386/i386.h @@ -73,8 +73,8 @@ struct stringop_algs { const enum stringop_alg unknown_size; const struct stringop_strategy { - const int max; - const enum stringop_alg alg; + int max; + enum stringop_alg alg; int noalign; } size [MAX_STRINGOP_ALGS]; }; -- Alan Modra Australia Development Lab, IBM