From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id F1FF7385E455 for ; Wed, 5 May 2021 08:20:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F1FF7385E455 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=derodat@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id CA3D7116F77; Wed, 5 May 2021 04:20:04 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id mfZxBcA8LY8f; Wed, 5 May 2021 04:20:04 -0400 (EDT) Received: from tron.gnat.com (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) by rock.gnat.com (Postfix) with ESMTP id B75FA116E67; Wed, 5 May 2021 04:20:04 -0400 (EDT) Received: by tron.gnat.com (Postfix, from userid 4862) id B6983103; Wed, 5 May 2021 04:20:04 -0400 (EDT) Date: Wed, 5 May 2021 04:20:04 -0400 From: Pierre-Marie de Rodat To: gcc-patches@gcc.gnu.org Cc: Piotr Trojanek Subject: [Ada] Set constraint error on real division just like on integer division Message-ID: <20210505082004.GA31140@adacore.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="AqsLC8rIMeq19msA" Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 May 2021 08:20:07 -0000 --AqsLC8rIMeq19msA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In Eval_Arithmetic_Op we set Raises_Constraint_Error flag on integer division by zero, but we didn't set it for real division by zero. This only affects GNATprove, because GNAT sets this flag inside Apply_Compile_Time_Constraint_Error (which has an early return guarded by GNATprove_Mode). Possibly the Raises_Constraint_Error flag should be only set inside Apply_Compile_Time_Constraint_Error, but at least this patch allows GNATprove to be have consistently for integer and real division by zero. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * sem_eval.adb (Eval_Arithmetic_Op): Call Set_Raises_Constraint_Error on real division by zero just like it is called for integer division by zero earlier in this routine. --AqsLC8rIMeq19msA Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="patch.diff" diff --git a/gcc/ada/sem_eval.adb b/gcc/ada/sem_eval.adb --- a/gcc/ada/sem_eval.adb +++ b/gcc/ada/sem_eval.adb @@ -2226,6 +2226,7 @@ package body Sem_Eval is if UR_Is_Zero (Right_Real) then Apply_Compile_Time_Constraint_Error (N, "division by zero", CE_Divide_By_Zero); + Set_Raises_Constraint_Error (N); return; end if; --AqsLC8rIMeq19msA--