From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, Tom de Vries <tdevries@suse.de>
Subject: Re: [Patch] + [nvptx RFH/RFC]: OpenMP: Fix SIMT for complex/float reduction with && and ||
Date: Thu, 6 May 2021 12:30:19 +0200 [thread overview]
Message-ID: <20210506103019.GZ1179226@tucnak> (raw)
In-Reply-To: <da832c1c-fd40-c73e-b0b7-a5f003ad1e52@codesourcery.com>
On Thu, May 06, 2021 at 12:17:03PM +0200, Tobias Burnus wrote:
> OpenMP: Fix SIMT for complex/float reduction with && and ||
>
> gcc/ChangeLog:
>
> * omp-low.c (lower_rec_input_clauses): Also handle SIMT part
> for complex/float recution with && and ||.
>
> libgomp/ChangeLog:
>
> * testsuite/libgomp.c-c++-common/reduction-5.c: New test, testing
> complex/floating-point || + && recduction with 'omp target'.
As the float/complex ||/&& reductions are IMHO just conformance issues, not
something anyone would actually use in meaningful code - floats or complex
aren't the most obvious or efficient holders of boolean values - I think
punting SIMT on those isn't a workaround, but the right solution.
Jakub
next prev parent reply other threads:[~2021-05-06 10:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 10:17 Tobias Burnus
2021-05-06 10:30 ` Jakub Jelinek [this message]
2021-05-06 13:12 ` Tom de Vries
2021-05-06 13:22 ` Jakub Jelinek
2021-05-06 14:05 ` Tom de Vries
2021-05-06 14:21 ` Tobias Burnus
2021-05-06 14:32 ` Jakub Jelinek
2021-05-07 10:05 ` Tobias Burnus
2021-05-07 10:06 ` Jakub Jelinek
2021-05-07 10:08 ` Tom de Vries
2021-05-18 11:07 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506103019.GZ1179226@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tdevries@suse.de \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).