From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 87742398B888 for ; Tue, 11 May 2021 17:12:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 87742398B888 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-306-gLZ5utOCNeaIH6aZGwtXiA-1; Tue, 11 May 2021 13:12:06 -0400 X-MC-Unique: gLZ5utOCNeaIH6aZGwtXiA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BF261107ACCA; Tue, 11 May 2021 17:12:05 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-114-59.ams2.redhat.com [10.36.114.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 640F31893C; Tue, 11 May 2021 17:12:05 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 14BHC2A6804897 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 11 May 2021 19:12:02 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 14BHC2WY804896; Tue, 11 May 2021 19:12:02 +0200 Date: Tue, 11 May 2021 19:12:02 +0200 From: Jakub Jelinek To: Jonathan Wakely Cc: Patrick Palka , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] libstdc++: Remove extern "C" from Ryu sources Message-ID: <20210511171202.GK1179226@tucnak> Reply-To: Jakub Jelinek References: <20210511142427.221984-1-ppalka@redhat.com> <75e0367d-4fc-4de5-c96b-fe839cf547@idea> <20210511165125.GX3008@redhat.com> <6bdc4ee6-522e-1ccf-3318-1c18e18728ca@idea> <20210511170719.GY3008@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210511170719.GY3008@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 May 2021 17:12:09 -0000 On Tue, May 11, 2021 at 06:07:19PM +0100, Jonathan Wakely via Gcc-patches wrote: > > I'm not sure if the abort call is necessary since the link step already > > fails with a multiple definition error (without the fix) even if the > > function is defined with an empty body. But since Jakub included an > > abort call in his testcase I carried it over :) Shall I just make it > > dg-do run, or perhaps keep it dg-do link and make the function body > > empty? Either seems to do the right thing. > > OK, if it works as-is then let's leave it as a link test. I think > having the abort there is likely to confuse me again in future when I > forget this conversation, so let's go with an empty body. When mentioning it on IRC, I didn't think of it failing already at link time, had the mental model of binary + shared library that just exports that symbol, so kind like a small shared library containing that std::to_chars(x, x+64, 42.L, std::chars_format::scientific); in some function, linked with -shared -fpic -static-libstdc++ and then binary with that generic_to_chars function extern "C" and main calling the shared library case. In the end, both that and the dg-do link testcase should catch it fine. Jakub