From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <segher@kernel.crashing.org>
Received: from gate.crashing.org (gate.crashing.org [63.228.1.57])
 by sourceware.org (Postfix) with ESMTP id B4856385380C
 for <gcc-patches@gcc.gnu.org>; Wed, 12 May 2021 23:20:12 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B4856385380C
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none)
 header.from=kernel.crashing.org
Authentication-Results: sourceware.org;
 spf=fail smtp.mailfrom=segher@kernel.crashing.org
Received: from gate.crashing.org (localhost.localdomain [127.0.0.1])
 by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 14CNJBWL031856;
 Wed, 12 May 2021 18:19:12 -0500
Received: (from segher@localhost)
 by gate.crashing.org (8.14.1/8.14.1/Submit) id 14CNJB1b031854;
 Wed, 12 May 2021 18:19:11 -0500
X-Authentication-Warning: gate.crashing.org: segher set sender to
 segher@kernel.crashing.org using -f
Date: Wed, 12 May 2021 18:19:10 -0500
From: Segher Boessenkool <segher@kernel.crashing.org>
To: will schmidt <will_schmidt@vnet.ibm.com>
Cc: Bill Schmidt <wschmidt@linux.ibm.com>, gcc-patches@gcc.gnu.org,
 dje.gcc@gmail.com
Subject: Re: [PATCH 3/4] rs6000: Conditionally define __ROP_PROTECT__
Message-ID: <20210512231910.GB10366@gate.crashing.org>
References: <cover.1619400506.git.wschmidt@linux.ibm.com>
 <5ff87a6cff8fe7bdf0cc4df44b7c8968e8b5ae50.1619400506.git.wschmidt@linux.ibm.com>
 <8c4e2c9fc64cd296b530cf4b523d715b239fcb1a.camel@vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8c4e2c9fc64cd296b530cf4b523d715b239fcb1a.camel@vnet.ibm.com>
User-Agent: Mutt/1.4.2.3i
X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, TXREP, T_SPF_HELO_PERMERROR,
 T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 12 May 2021 23:20:13 -0000

On Mon, Apr 26, 2021 at 11:03:22AM -0500, will schmidt wrote:
> On Sun, 2021-04-25 at 20:50 -0500, Bill Schmidt via Gcc-patches wrote:
> > @@ -602,6 +602,9 @@ rs6000_target_modify_macros (bool define_p, HOST_WIDE_INT flags,
> >    /* Whether pc-relative code is being generated.  */
> >    if ((flags & OPTION_MASK_PCREL) != 0)
> >      rs6000_define_or_undefine_macro (define_p, "__PCREL__");
> > +  /* Tell the user -mrop-protect is in play.  */
> > +  if (rs6000_rop_protect)
> > +    rs6000_define_or_undefine_macro (define_p, "__ROP_PROTECT__");
> > 
> 
> I notice that almost all of the other defines are controled by an (if
> (flags & OPTION) logic block.. but this seems OK.

That is rs6000_isa_flags, which is only 64 bits.  Not every option can
be put in there, only the ones used all over the place in the compiler
should be.  Currently there are 53 of 64 bits used, there is some room,
and that is good :-)


Segher