From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 1E18D3847839; Mon, 17 May 2021 14:11:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1E18D3847839 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Julian_Brown@mentor.com IronPort-SDR: 37ztOCXqbAXLa42DUU2+/Y6jWaJNsGDEwHFIE+RIlvhlSB1i/4DkD0DVs9j41/dv/TAdxI/TRH e7CwFeXRXEb+zAu5EyY+EGHikKC//zf+Z5xTCU6drxbTHOcLREkJyvq36NOp6hQKNn/7aG5DBg q5douc5M2v8q4tAl0S/8NuSGrpCYNJPTZ/3CnQ56OxovEAQeurtNZev2qzY27rUMt1tMuRFVIi KxvIv0RQKCkRomcOOqaBtQryXRV9AnMfrECCTaInpGLtOOWnnqUMy7sMmZETE+3/jQBz2R3Vav pDA= X-IronPort-AV: E=Sophos;i="5.82,307,1613462400"; d="scan'208";a="61428431" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 17 May 2021 06:11:03 -0800 IronPort-SDR: txXvurdS90JS9KincF1KG07DgMXzhpzbjKLKu97qli2m4Zmh0/QM/l6yHcuWyJihR9XSs75D8l 2kOWgKKCvfRWu2cRts9kuOSXmA7tEvIhS3zV5vdGb9QrDHT10jqCmFINY5jfXt2jEoc2BTcn9y sR2eSpftSxkSt7GMfYEEfbE+XhSYtr7hz7ajEkjEd4xELXSNDbp3W/yeQoreEju33G05NebQt/ xFG0rzH/w8leX2CfLdUDQtYIeZlFVyNchyaN1zfsyuQnCo1sZZOC20yvoFSEErGAS1xmy0zOXW yoE= Date: Mon, 17 May 2021 15:10:56 +0100 From: Julian Brown To: Bernd Edlinger CC: , Jakub Jelinek , "Tobias Burnus" , Chung-Lin Tang , Thomas Schwinge , Subject: Re: [PATCH 4/5] Rework indirect struct handling for OpenACC/OpenMP in gimplify.c Message-ID: <20210517151056.47b83035@squid.athome> In-Reply-To: References: Organization: Mentor Graphics X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 May 2021 14:11:15 -0000 On Mon, 17 May 2021 14:12:00 +0200 Bernd Edlinger wrote: > > */ @@ -8715,19 +8770,26 @@ static tree > > build_struct_group (struct gimplify_omp_ctx *ctx, > > enum omp_region_type region_type, enum > > tree_code code, tree decl, unsigned int *flags, tree c, > > - hash_map *&struct_map_to_clause, > > + hash_map > > *&struct_map_to_clause, tree *&prev_list_p, tree *&list_p, bool > > *cont) { > > poly_offset_int coffset; > > poly_int64 cbitpos; > > - tree base_ref; > > + tree base_ind, base_ref; > > + tree *list_in_p =3D list_p, *prev_list_in_p =3D prev_list_p; > > =20 >=20 > Is this a kind of debug code? > This fails to compile: >=20 > ../../gcc-trunk/gcc/gimplify.c: In function =E2=80=98tree_node* > build_struct_group(gimplify_omp_ctx*, omp_region_type, tree_code, > tree, unsigned int*, tree, hash_map*&, > tree_node**&, tree_node**&, bool*)=E2=80=99: > ../../gcc-trunk/gcc/gimplify.c:8779:9: error: unused variable > =E2=80=98list_in_p=E2=80=99 [-Werror=3Dunused-variable] 8779 | tree *li= st_in_p =3D > list_p, *prev_list_in_p =3D prev_list_p; | ^~~~~~~~~ > ../../gcc-trunk/gcc/gimplify.c:8779:30: error: unused variable > =E2=80=98prev_list_in_p=E2=80=99 [-Werror=3Dunused-variable] 8779 | tre= e *list_in_p =3D > list_p, *prev_list_in_p =3D prev_list_p; | > ^~~~~~~~~~~~~~ Oops, that's left over from an earlier iteration of the patch, and indeed isn't needed any more. I'll be sure to bootstrap the next iteration of these patches I send upstream. Thanks, Julian