From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 3D308383F43D for ; Tue, 18 May 2021 19:16:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3D308383F43D Received: by mail-pf1-x42b.google.com with SMTP id q2so8122468pfh.13 for ; Tue, 18 May 2021 12:16:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5usSWZzW0o/w+35kc6ispSSh+PVUg2juIBqgtowxjDc=; b=SiUERWHYd8A+Gjh1CS4FGzYxfq+iO0WDPiLvn+ohbAW6jbh+agfKT+73O4aMvdMlEB dC4f8X12Fb/KuTiU28OXqqoonO3n6F7DZV6sPUZeGOvbMJNUWMofO7FVlZSV03IJKMgU LZM5jZE8Nh6j29qy/0W4MgpTiubmw/iqA1PH9y7tGZJHk9Uo1T9QeGN424lsiyYwf2wj aYRhteV1wY2wZ7/c8dgDy0GdcRBOmc6GWze9QHs/yQUvcbwhzUE1mUQwNC1tit/p4REq He+Mr6aR8Adk0XOHZM3Do6jDROztPFgwjUOPbuGjLIESivrU8tP/mtVId7r4BbeswxRN zutQ== X-Gm-Message-State: AOAM531ErLw3yKEAZdjKZNpKRgid+a6V1uIC+0xt1vhGeo+amoeS7my5 K7/Q3VN72vqT0V0xkha7lcY= X-Google-Smtp-Source: ABdhPJwreGs0gFHBTCNBp2lN+Qmt1zeARRwZtUDTR8Xngx+6ylgANUdZolPhoK9NjYgd+QuQLYyArg== X-Received: by 2002:a63:1906:: with SMTP id z6mr6642249pgl.289.1621365409373; Tue, 18 May 2021 12:16:49 -0700 (PDT) Received: from gnu-cfl-2.localdomain ([172.56.39.231]) by smtp.gmail.com with ESMTPSA id x19sm10488351pfp.153.2021.05.18.12.16.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 May 2021 12:16:47 -0700 (PDT) Received: from gnu-cfl-2.. (localhost [IPv6:::1]) by gnu-cfl-2.localdomain (Postfix) with ESMTP id 6FD33C047F; Tue, 18 May 2021 12:16:46 -0700 (PDT) From: "H.J. Lu" To: gcc-patches@gcc.gnu.org Cc: Richard Biener , Richard Sandiford , Uros Bizjak , Bernd Edlinger Subject: [PATCH v4 03/12] x86: Avoid stack realignment when copying data Date: Tue, 18 May 2021 12:16:37 -0700 Message-Id: <20210518191646.3071005-4-hjl.tools@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210518191646.3071005-1-hjl.tools@gmail.com> References: <20210518191646.3071005-1-hjl.tools@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3035.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 May 2021 19:16:51 -0000 To avoid stack realignment, use SCRATCH_SSE_REG to copy data from one memory location to another. gcc/ * config/i386/i386-expand.c (ix86_expand_vector_move): Use SCRATCH_SSE_REG to copy data from one memory location to another. gcc/testsuite/ * gcc.target/i386/eh_return-1.c: New test. --- gcc/config/i386/i386-expand.c | 16 ++++++++++++- gcc/testsuite/gcc.target/i386/eh_return-1.c | 26 +++++++++++++++++++++ 2 files changed, 41 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.target/i386/eh_return-1.c diff --git a/gcc/config/i386/i386-expand.c b/gcc/config/i386/i386-expand.c index a9fe31fcb39..28f4f9b0e10 100644 --- a/gcc/config/i386/i386-expand.c +++ b/gcc/config/i386/i386-expand.c @@ -435,7 +435,21 @@ ix86_expand_vector_move (machine_mode mode, rtx operands[]) && !register_operand (op0, mode) && !register_operand (op1, mode)) { - emit_move_insn (op0, force_reg (GET_MODE (op0), op1)); + rtx tmp; + mode = GET_MODE (op0); + if (TARGET_SSE + && (GET_MODE_ALIGNMENT (mode) + > ix86_minimum_incoming_stack_boundary (false, true))) + { + /* NB: Don't increase stack alignment requirement by using + a scratch SSE register to copy data from one memory + location to another since it doesn't require a spill. */ + tmp = gen_rtx_REG (mode, SCRATCH_SSE_REG); + emit_move_insn (tmp, op1); + } + else + tmp = force_reg (mode, op1); + emit_move_insn (op0, tmp); return; } diff --git a/gcc/testsuite/gcc.target/i386/eh_return-1.c b/gcc/testsuite/gcc.target/i386/eh_return-1.c new file mode 100644 index 00000000000..671ba635e88 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/eh_return-1.c @@ -0,0 +1,26 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -march=haswell -mno-avx512f" } */ + +struct _Unwind_Context +{ + void *ra; + char array[48]; +}; + +extern long uw_install_context_1 (struct _Unwind_Context *); + +void +_Unwind_RaiseException (void) +{ + struct _Unwind_Context this_context, cur_context; + long offset = uw_install_context_1 (&this_context); + __builtin_memcpy (&this_context, &cur_context, + sizeof (struct _Unwind_Context)); + void *handler = __builtin_frob_return_addr ((&cur_context)->ra); + uw_install_context_1 (&cur_context); + __builtin_eh_return (offset, handler); +} + +/* { dg-final { scan-assembler-times "vmovdqu\[ \\t\]+\[^\n\]*%ymm" 4 } } */ +/* No need to dynamically realign the stack here. */ +/* { dg-final { scan-assembler-not "and\[^\n\r]*%\[re\]sp" } } */ -- 2.31.1