From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 813FB3952509 for ; Thu, 27 May 2021 07:20:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 813FB3952509 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-231-KfnHhSQWMjaE4lZLeevZSQ-1; Thu, 27 May 2021 03:20:12 -0400 X-MC-Unique: KfnHhSQWMjaE4lZLeevZSQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 00EB3107ACC7; Thu, 27 May 2021 07:20:11 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-147.ams2.redhat.com [10.36.112.147]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2556490BE; Thu, 27 May 2021 07:20:09 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 14R7K7vv624175 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 27 May 2021 09:20:07 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 14R7K6u4624174; Thu, 27 May 2021 09:20:06 +0200 Date: Thu, 27 May 2021 09:20:06 +0200 From: Jakub Jelinek To: Hongtao Liu , Richard Sandiford , Eric Botcazou Cc: gcc-patches@gcc.gnu.org, Uros Bizjak , "H. J. Lu" Subject: Re: [PATCH] [i386] Fix _mm256_zeroupper to notify LRA that vzeroupper will kill sse registers. [PR target/82735] Message-ID: <20210527072006.GL7746@tucnak> Reply-To: Jakub Jelinek References: <20210513113704.GI1179226@tucnak> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 May 2021 07:20:15 -0000 On Thu, May 27, 2021 at 01:07:09PM +0800, Hongtao Liu via Gcc-patches wrote: > + /* Flag used for call_insn indicates it's a fake call. */ > + RTX_FLAG (insn, used) = 1; > + /* CALL_INSN use "used" flag to indicate it's a fake call. */ > + if (i == STACK_POINTER_REGNUM > + && !RTX_FLAG (insn_info->insn, used)) > - && ! SIBLING_CALL_P (insn)) > + && ! SIBLING_CALL_P (insn) > + && !RTX_FLAG (insn, used)) > - /* For all other RTXes clear the used flag on the copy. */ > - RTX_FLAG (copy, used) = 0; > + /* For all other RTXes clear the used flag on the copy. > + CALL_INSN use "used" flag to indicate it's a fake call. */ > + if (!INSN_P (orig)) > + RTX_FLAG (copy, used) = 0; > break; > } > return copy; > @@ -57,7 +57,8 @@ requires_stack_frame_p (rtx_insn *insn, HARD_REG_SET prologue_used, > HARD_REG_SET hardregs; > unsigned regno; > > - if (CALL_P (insn)) > + /* CALL_INSN use "used" flag to indicate it's a fake call. */ > + if (CALL_P (insn) && !RTX_FLAG (insn, used)) > return !SIBLING_CALL_P (insn); Please define a macro for this in rtl.h (and mention it above used; member too in a comment, see all the other comments in there), like: /* 1 if RTX is a call_insn for a fake call. */ #define FAKE_CALL_P(RTX) \ (RTL_FLAG_CHECK1 ("FAKE_CALL_P", (RTX), CALL_INSN)->used) Though, I'm also not sure if used can be actually used for this, because it is used e.g. in emit-rtl.c for verification of RTL sharing. Though, it seems no other rtl flag is free for CALL_INSN. Could this fake call flag sit on the CALL rtx instead? Jakub