From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 278BD3858023 for ; Thu, 27 May 2021 15:05:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 278BD3858023 Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-551-J7k86OYIPkauISFd-G0gRw-1; Thu, 27 May 2021 11:05:20 -0400 X-MC-Unique: J7k86OYIPkauISFd-G0gRw-1 Received: by mail-qv1-f70.google.com with SMTP id fi6-20020a0562141a46b02901f064172b74so310469qvb.3 for ; Thu, 27 May 2021 08:05:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=np7y61Bb89dPLmD+IGKcz+T7jIYY3tcGaks/Qu0Ioyk=; b=my8v1Wy0WxxHaJo2e4KtRjst+8IDqkKau/BcPgP+jkXAUlN3ExmXD53G7PNZ+BAR0g XOpLyWQkeYA7nEEMpBFNazCRvj4LlQAWppJSw7fWl31gOoDNAYPf9MSG9Uxbu2A4FG62 /Jht/TD/vowiBoVLEy9uU80REKSYpXGSYDol8c6b/tmGnfa9j16fsWsoGc4feA0mkNH0 SuNP8pZdW6eCIcWasayTsz3t+zvEY0dsZWE5Wd5J48MVmcEVNSHfRUrDPm7TwxSAZqxk UGZtpAwf4qppljQdekhrA++CqmkBu80LSaBBphpE25nmPVPtAzXWn/5RuwpBe8+Y2voh nCyA== X-Gm-Message-State: AOAM5333szv4vsuNWycHFNWlVeZGwcsIar6iGHRms25XjgSMuPchfghd Ge31eeEIfmLoSBNvwAkMHjhd3v1kGzmtGyJQ4OXbre8zTCNU+/IkgPnpd0lkrkcAT6tfJiky/AL BE/5p68dYVyoPnhp3Hnsb/T2GiZg/Uu5Enlu1dLJSx2cy3mdM/npSwXmWY/6SOrxUbCk= X-Received: by 2002:a05:622a:143:: with SMTP id v3mr3507278qtw.197.1622127919923; Thu, 27 May 2021 08:05:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcd/Ib7xm0cPYxfrbd2M5inNgeiDvVHJdldLSJvm4sMTCmCDiD6KdqKEVa0nCYq55EI75A3Q== X-Received: by 2002:a05:622a:143:: with SMTP id v3mr3507245qtw.197.1622127919616; Thu, 27 May 2021 08:05:19 -0700 (PDT) Received: from localhost.localdomain (ool-457d493a.dyn.optonline.net. [69.125.73.58]) by smtp.gmail.com with ESMTPSA id q185sm1500239qkd.69.2021.05.27.08.05.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 May 2021 08:05:19 -0700 (PDT) From: Patrick Palka To: gcc-patches@gcc.gnu.org Subject: [PATCH] c++: parameter pack inside static_assert [PR99893] Date: Thu, 27 May 2021 11:05:17 -0400 Message-Id: <20210527150517.3398785-1-ppalka@redhat.com> X-Mailer: git-send-email 2.32.0.rc0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-Spam-Status: No, score=-16.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 May 2021 15:05:24 -0000 Here, we're not finding the parameter pack inside the static_assert because STATIC_ASSERT trees are tcc_exceptional, and we weren't explicitly walking them in cp_walk_subtrees. Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? gcc/cp/ChangeLog: PR c++/99893 * tree.c (cp_walk_subtrees) : New case. gcc/testsuite/ChangeLog: PR c++/99893 * g++.dg/cpp0x/static_assert17.C: New test. --- gcc/cp/tree.c | 5 +++++ gcc/testsuite/g++.dg/cpp0x/static_assert17.C | 9 +++++++++ 2 files changed, 14 insertions(+) create mode 100644 gcc/testsuite/g++.dg/cpp0x/static_assert17.C diff --git a/gcc/cp/tree.c b/gcc/cp/tree.c index 372d89fa9ed..fec5afaa2be 100644 --- a/gcc/cp/tree.c +++ b/gcc/cp/tree.c @@ -5446,6 +5446,11 @@ cp_walk_subtrees (tree *tp, int *walk_subtrees_p, walk_tree_fn func, } break; + case STATIC_ASSERT: + WALK_SUBTREE (STATIC_ASSERT_CONDITION (*tp)); + WALK_SUBTREE (STATIC_ASSERT_MESSAGE (*tp)); + break; + default: return NULL_TREE; } diff --git a/gcc/testsuite/g++.dg/cpp0x/static_assert17.C b/gcc/testsuite/g++.dg/cpp0x/static_assert17.C new file mode 100644 index 00000000000..64843c60edd --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/static_assert17.C @@ -0,0 +1,9 @@ +// PR c++/99893 +// { dg-do compile { target c++11 } } + +void f(...); + +template +void g() { + f([] { static_assert(Ts::value, ""); }...); +} -- 2.32.0.rc0