public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [wwwdocs] lists: Fix thinko
@ 2021-06-01 21:49 Segher Boessenkool
  2021-06-02  7:17 ` Gerald Pfeifer
  2021-06-02  8:25 ` Andreas Schwab
  0 siblings, 2 replies; 5+ messages in thread
From: Segher Boessenkool @ 2021-06-01 21:49 UTC (permalink / raw)
  To: gcc-patches; +Cc: Segher Boessenkool

Brown paper bag time.  The List-Id: should look like a hostname, not
like an email address.  Somehow I put in an at-sign when changing my
gcc-patches example to the match-all example we have here.

Note that the "." in the procmail match are RE wildcards btw.  This is
common practice in procmailrcs, although not necessarily a good idea :-)

Thanks to Andreas Schwab for noticing.  Committed.


Segher
---
 htdocs/lists.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/lists.html b/htdocs/lists.html
index 4ac5d5a84cd1..e9636198b732 100644
--- a/htdocs/lists.html
+++ b/htdocs/lists.html
@@ -226,7 +226,7 @@ our lists into a single folder named INLIST.gcc:</p>
 
 <blockquote><p><code>
 :0<br />
-* ^List-Id: .*<.*@gcc.gnu.org>$<br />
+* ^List-Id: .*<.*.gcc.gnu.org>$<br />
 INLIST.gcc<br />
 </code></p></blockquote>
 
@@ -235,7 +235,7 @@ can use the following recipe (Use at your own risk!):</p>
 
 <blockquote><p><code>
 :0 Wh: msgid.lock<br />
-* ^List-Id: .*<.*@gcc.gnu.org>$<br />
+* ^List-Id: .*<.*.gcc.gnu.org>$<br />
 | formail -D 8192 msgid.cache
 </code></p></blockquote>
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [wwwdocs] lists: Fix thinko
  2021-06-01 21:49 [wwwdocs] lists: Fix thinko Segher Boessenkool
@ 2021-06-02  7:17 ` Gerald Pfeifer
  2021-06-02 16:27   ` Segher Boessenkool
  2021-06-02  8:25 ` Andreas Schwab
  1 sibling, 1 reply; 5+ messages in thread
From: Gerald Pfeifer @ 2021-06-02  7:17 UTC (permalink / raw)
  To: Segher Boessenkool; +Cc: gcc-patches

On Tue, 1 Jun 2021, Segher Boessenkool wrote:
> Brown paper bag time.  The List-Id: should look like a hostname, not
> like an email address.  Somehow I put in an at-sign when changing my
> gcc-patches example to the match-all example we have here.

That's how things looked like before when using the Sender: header,
for example. So totally understandable.

Thanks for making these changes!

> -* ^List-Id: .*<.*@gcc.gnu.org>$<br />
> +* ^List-Id: .*<.*.gcc.gnu.org>$<br />

In my own filters I use

     ^List-Id: .*gcc.gnu.org

to make it simpler and increase robustness around "<" and ">" (and "$").

Or   ^List-Id: .*gcc(-announce|-patches|-cvs-wwwdocs)?.gcc.gnu.org  in
one case.

What do you think?

Gerald

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [wwwdocs] lists: Fix thinko
  2021-06-01 21:49 [wwwdocs] lists: Fix thinko Segher Boessenkool
  2021-06-02  7:17 ` Gerald Pfeifer
@ 2021-06-02  8:25 ` Andreas Schwab
  2021-06-02 16:27   ` Segher Boessenkool
  1 sibling, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2021-06-02  8:25 UTC (permalink / raw)
  To: Segher Boessenkool; +Cc: gcc-patches

On Jun 01 2021, Segher Boessenkool wrote:

> diff --git a/htdocs/lists.html b/htdocs/lists.html
> index 4ac5d5a84cd1..e9636198b732 100644
> --- a/htdocs/lists.html
> +++ b/htdocs/lists.html
> @@ -226,7 +226,7 @@ our lists into a single folder named INLIST.gcc:</p>
>  
>  <blockquote><p><code>
>  :0<br />
> -* ^List-Id: .*<.*@gcc.gnu.org>$<br />
> +* ^List-Id: .*<.*.gcc.gnu.org>$<br />

Shouldn't the < and > be mangled as &lt; and &gt;?

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [wwwdocs] lists: Fix thinko
  2021-06-02  7:17 ` Gerald Pfeifer
@ 2021-06-02 16:27   ` Segher Boessenkool
  0 siblings, 0 replies; 5+ messages in thread
From: Segher Boessenkool @ 2021-06-02 16:27 UTC (permalink / raw)
  To: Gerald Pfeifer; +Cc: gcc-patches

On Wed, Jun 02, 2021 at 09:17:20AM +0200, Gerald Pfeifer wrote:
> On Tue, 1 Jun 2021, Segher Boessenkool wrote:
> > Brown paper bag time.  The List-Id: should look like a hostname, not
> > like an email address.  Somehow I put in an at-sign when changing my
> > gcc-patches example to the match-all example we have here.
> 
> That's how things looked like before when using the Sender: header,
> for example. So totally understandable.

And the existing example (like most procmail recipes) uses unescaped dot
where a literal dot would perhaps be better.

> > -* ^List-Id: .*<.*@gcc.gnu.org>$<br />
> > +* ^List-Id: .*<.*.gcc.gnu.org>$<br />
> 
> In my own filters I use
> 
>      ^List-Id: .*gcc.gnu.org
> 
> to make it simpler and increase robustness around "<" and ">" (and "$").

And decrease robustness elsewhere (it now will match any list id that
has the string gccXgnuYorg anywhere in it, where X and Y can be any
character).

> Or   ^List-Id: .*gcc(-announce|-patches|-cvs-wwwdocs)?.gcc.gnu.org  in
> one case.
> 
> What do you think?

I only filter "gcc", "gcc-patches", "gcc-bugs" myself, all to separate
folders.

I use  .*<...>$  on all lists I have everywhere, it works fine for me.
It already isn't super strict, and more lax might work fine as well
(there is absolutely nothing that prevents anyone from sending specially
crafted emails to wreak havoc on everyone's filters anyway).

If you change the example, maybe make it less peculiar at the same time?
Filtering a high-traffic list like gcc-patches to the same folder as
gcc-announce is a strange thing to do.

(And please do make a change, so I don't have to brown-paper-bag a
second time, this time for &lt;, sigh).


Segher

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [wwwdocs] lists: Fix thinko
  2021-06-02  8:25 ` Andreas Schwab
@ 2021-06-02 16:27   ` Segher Boessenkool
  0 siblings, 0 replies; 5+ messages in thread
From: Segher Boessenkool @ 2021-06-02 16:27 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: gcc-patches

On Wed, Jun 02, 2021 at 10:25:34AM +0200, Andreas Schwab wrote:
> On Jun 01 2021, Segher Boessenkool wrote:
> > -* ^List-Id: .*<.*@gcc.gnu.org>$<br />
> > +* ^List-Id: .*<.*.gcc.gnu.org>$<br />
> 
> Shouldn't the < and > be mangled as &lt; and &gt;?

"It works fine for me!"

You are right of course.


Segher

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-06-02 16:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 21:49 [wwwdocs] lists: Fix thinko Segher Boessenkool
2021-06-02  7:17 ` Gerald Pfeifer
2021-06-02 16:27   ` Segher Boessenkool
2021-06-02  8:25 ` Andreas Schwab
2021-06-02 16:27   ` Segher Boessenkool

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).