public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Xionghu Luo <luoxhu@linux.ibm.com>
Cc: gcc-patches@gcc.gnu.org, dje.gcc@gmail.com,
	wschmidt@linux.ibm.com, guojiufu@linux.ibm.com,
	linkw@gcc.gnu.org
Subject: Re: [PATCH] rs6000: Support doubleword swaps removal in rot64 load store [PR100085]
Date: Wed, 2 Jun 2021 17:20:03 -0500	[thread overview]
Message-ID: <20210602222003.GJ18427@gate.crashing.org> (raw)
In-Reply-To: <20210602081932.2683429-1-luoxhu@linux.ibm.com>

On Wed, Jun 02, 2021 at 03:19:32AM -0500, Xionghu Luo wrote:
> On P8LE, extra rot64+rot64 load or store instructions are generated
> in float128 to vector __int128 conversion.
> 
> This patch teaches pass swaps to also handle such pattens to remove
> extra swap instructions.

Did you check if this is already handled by simplify-rtx if the mode had
been TImode (not V1TImode)?  If not, why do you not handle it there?

> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/powerpc/pr100085.c
> @@ -0,0 +1,28 @@
> +/* { dg-do compile { target { powerpc*-*-linux* } } } */

Just
  /* { dg-do compile } */
please (or is there any reason to do this on linux only?)

> +/* { dg-require-effective-target powerpc_float128_sw_ok } */
> +/* { dg-options "-O2 -mdejagnu-cpu=power8 -mfloat128 -mno-regnames" } */

-mfloat128 is implied by -mcpu=power8.  Why do you use -mno-regnames?

> +#ifndef __FLOAT128__
> +#error "-mfloat128 is not supported."
> +#endif

So this can be deleted as well.


Segher

  reply	other threads:[~2021-06-02 22:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02  8:19 Xionghu Luo
2021-06-02 22:20 ` Segher Boessenkool [this message]
2021-06-03  0:46   ` Xionghu Luo
2021-06-03  6:49     ` Xionghu Luo
2021-06-03 20:31       ` Segher Boessenkool
2021-06-04  1:40         ` Xionghu Luo
2021-06-08 20:11           ` Segher Boessenkool
2021-06-09  3:20             ` Xionghu Luo
2021-06-09 16:24               ` Segher Boessenkool
2021-06-10  7:11                 ` Xionghu Luo
2021-06-11 20:16                   ` Segher Boessenkool
2021-06-16  1:39                     ` Xionghu Luo
2021-06-03 13:09     ` Bill Schmidt
2021-06-03 20:19       ` Segher Boessenkool
2021-06-03 20:34         ` Bill Schmidt
2021-06-04  2:15       ` Xionghu Luo
2021-06-03 20:16     ` Segher Boessenkool
2021-06-04  2:45       ` Xionghu Luo
2021-06-08  1:11   ` [PATCH v2] " Xionghu Luo
2021-06-08 21:07     ` Segher Boessenkool
2021-06-09  3:06       ` Xionghu Luo
2021-06-09 16:47         ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210602222003.GJ18427@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=guojiufu@linux.ibm.com \
    --cc=linkw@gcc.gnu.org \
    --cc=luoxhu@linux.ibm.com \
    --cc=wschmidt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).