From: Segher Boessenkool <segher@kernel.crashing.org>
To: Aaron Sawdey <acsawdey@linux.ibm.com>
Cc: gcc-patches@gcc.gnu.org, wschmidt@linux.ibm.com,
will_schmidt@vnet.ibm.com
Subject: Re: [PATCH,rs6000] Fix operand order to subf for p10 fusion.
Date: Thu, 3 Jun 2021 00:19:46 -0500 [thread overview]
Message-ID: <20210603051946.GR18427@gate.crashing.org> (raw)
In-Reply-To: <20210603040500.58483-1-acsawdey@linux.ibm.com>
Hi!
On Wed, Jun 02, 2021 at 11:05:00PM -0500, Aaron Sawdey wrote:
> This certainly causes a bootstrap miscompare, and might also be
> responsible for PR/100820. The operands to subf were reversed
> in the logical-add/sub fusion patterns, and I screwed up my
> bootstrap test which is how it ended up getting committed.
>
> If bootstrap and regtest passes, ok for trunk (and eventual backport to 11.2)?
Yes for all. Thanks!
Super nit:
> * gcc/config/rs6000/genfusion.pl (gen_logical_addsubf): Fix input
> order to subf instruction.
> * gcc/config/rs6000/fusion.md: Regenerate input.
It is not the *input* you regenerated ;-) Just "Regenerate." is custom.
Segher
prev parent reply other threads:[~2021-06-03 5:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 4:05 Aaron Sawdey
2021-06-03 5:19 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210603051946.GR18427@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=acsawdey@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=will_schmidt@vnet.ibm.com \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).