From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 9E8193835406 for ; Mon, 7 Jun 2021 14:15:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9E8193835406 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-yfapI4IVNzuOqoysMIdJmA-1; Mon, 07 Jun 2021 10:15:32 -0400 X-MC-Unique: yfapI4IVNzuOqoysMIdJmA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A0F1E5122; Mon, 7 Jun 2021 14:15:30 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-147.ams2.redhat.com [10.36.112.147]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2C6EF5D6D3; Mon, 7 Jun 2021 14:15:29 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 157EFRkH4104823 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 7 Jun 2021 16:15:27 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 157EFQ0W4104822; Mon, 7 Jun 2021 16:15:26 +0200 Date: Mon, 7 Jun 2021 16:15:26 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , fortran Subject: Re: [Patch] Fortran/OpenMP: Fix clause splitting for target/parallel/teams [PR99928] Message-ID: <20210607141526.GI7746@tucnak> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2021 14:15:45 -0000 On Mon, Jun 07, 2021 at 03:21:10PM +0200, Tobias Burnus wrote: > +static void > +gfc_add_clause_implicitly (gfc_omp_clauses *clauses_out, > + gfc_omp_clauses *clauses_in, > + bool is_target, bool is_parallel_do) > +{ > + int clauselist_to_add = is_target ? OMP_LIST_MAP : OMP_LIST_SHARED; For SHARED and array sections on reduction shared should be for the whole variable rather than just the array section. But I guess that can be solved only when the support is there. > + if (clauses_out->lists[clauselist_to_add] > + && clauses_out->lists[clauselist_to_add] == clauses_in->lists[clauselist_to_add]) Too long line. Otherwise LGTM. Jakub