From: Segher Boessenkool <segher@kernel.crashing.org>
To: will schmidt <will_schmidt@vnet.ibm.com>
Cc: Michael Meissner <meissner@linux.ibm.com>,
gcc-patches@gcc.gnu.org, David Edelsohn <dje.gcc@gmail.com>,
Bill Schmidt <wschmidt@linux.ibm.com>,
Peter Bergner <bergner@linux.ibm.com>
Subject: Re: [PATCH 2/2] Add IEEE 128-bit fp conditional move on PowerPC.
Date: Mon, 7 Jun 2021 16:29:37 -0500 [thread overview]
Message-ID: <20210607212937.GO18427@gate.crashing.org> (raw)
In-Reply-To: <0e2fd73cd86dd40b090ad92ec26b2f27dc548f00.camel@vnet.ibm.com>
On Thu, May 20, 2021 at 02:27:06PM -0500, will schmidt wrote:
> On Tue, 2021-05-18 at 16:28 -0400, Michael Meissner wrote:
> > + if (compare_mode == result_mode
> > + || (compare_mode == SFmode && result_mode == DFmode)
> > + || (compare_mode == DFmode && result_mode == SFmode))
> > + ;
> > + else
> > + return false;
>
> Interesting if/else block. May want to reverse the logic. I defer if
> this way is notably simpler than inverting it.
This is not simpler, no. You want to do something that just returns
*first*, and then not have an "else". *That* is simpler.
And just write !(...) around the condition, don't try to manually invert
it please. You want both correct code and readable code, not neither of
these, they are not extremes you need to balance, each helps the other!
Segher
next prev parent reply other threads:[~2021-06-07 21:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 20:22 [PATCH 0/2] Add power10 IEEE 128-bit min/max/conditional move support Michael Meissner
2021-05-18 20:26 ` [PATCH 1/2] Add IEEE 128-bit min/max support on PowerPC Michael Meissner
2021-05-20 19:25 ` will schmidt
2021-05-21 1:38 ` Michael Meissner
2021-06-07 20:08 ` Segher Boessenkool
2021-05-24 15:47 ` Ping " Michael Meissner
2021-06-01 23:38 ` Ping #2: " Michael Meissner
2021-06-07 20:25 ` Segher Boessenkool
2021-06-08 23:52 ` Michael Meissner
2021-05-18 20:28 ` [PATCH 2/2] Add IEEE 128-bit fp conditional move " Michael Meissner
2021-05-20 19:27 ` will schmidt
2021-05-21 1:45 ` Michael Meissner
2021-06-07 21:29 ` Segher Boessenkool [this message]
2021-05-24 15:49 ` Ping " Michael Meissner
2021-06-01 23:39 ` Ping #2: " Michael Meissner
2021-06-07 22:31 ` Segher Boessenkool
2021-06-09 0:05 ` Michael Meissner
-- strict thread matches above, loose matches on Subject: below --
2021-04-15 15:57 [PATCH 0/2] Add IEEE 128-bit min/max/conditional move Michael Meissner
2021-04-15 16:05 ` [PATCH 2/2] Add IEEE 128-bit fp conditional move on PowerPC Michael Meissner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210607212937.GO18427@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.ibm.com \
--cc=will_schmidt@vnet.ibm.com \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).