From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 8DCD73848025 for ; Mon, 14 Jun 2021 17:08:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8DCD73848025 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-602-ux-AFb8YNOKXC-HtJ9B2XQ-1; Mon, 14 Jun 2021 13:08:46 -0400 X-MC-Unique: ux-AFb8YNOKXC-HtJ9B2XQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6C5F580293C; Mon, 14 Jun 2021 17:08:45 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-7.ams2.redhat.com [10.36.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BA4FF19D7D; Mon, 14 Jun 2021 17:08:44 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 15EH8fvq1833786 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 14 Jun 2021 19:08:42 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 15EH8eiL1833782; Mon, 14 Jun 2021 19:08:40 +0200 Date: Mon, 14 Jun 2021 19:08:40 +0200 From: Jakub Jelinek To: Peter Bergner Cc: Segher Boessenkool , GCC Patches Subject: Re: [PATCH] rs6000: MMA builtin usage ICEs when used in a #pragma omp parallel and using -fopenmp [PR100777] Message-ID: <20210614170840.GI7746@tucnak> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jun 2021 17:08:49 -0000 On Wed, May 26, 2021 at 04:16:31PM -0500, Peter Bergner via Gcc-patches wrote: > Using an MMA builtin within an openmp parallel code block leads to an SSA > verification ICE on the temporaries we create while expanding the MMA builtins > at gimple time. The solution is to use create_tmp_reg_or_ssa_name(), which > knows when to create either an SSA or register temporary. > > This fixes the ICE and bootstraps and regtests with no regressions. > Ok for trunk? LGTM. > > The same ICE occurs in GCC 11 and GCC 10. Ok to backport to those release > branches after some burn in on trunk? Yes. > > Peter > > > gcc/ > PR target/100777 > * config/rs6000/rs6000-call.c (rs6000_gimple_fold_mma_builtin): Use > create_tmp_reg_or_ssa_name(). > > gcc/testsuite/ > PR target/100777 > * gcc.target/powerpc/pr100777.c: New test. Jakub