From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id E6CFB385DC0C for ; Thu, 17 Jun 2021 12:27:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E6CFB385DC0C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-524-0OsEDyrLO0GmR8lL2jaNvQ-1; Thu, 17 Jun 2021 08:27:43 -0400 X-MC-Unique: 0OsEDyrLO0GmR8lL2jaNvQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 199DD8049F2; Thu, 17 Jun 2021 12:27:42 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-115-161.ams2.redhat.com [10.36.115.161]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7C28760CC9; Thu, 17 Jun 2021 12:27:41 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 15HCRdXV072064 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 17 Jun 2021 14:27:39 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 15HCRbEn072063; Thu, 17 Jun 2021 14:27:37 +0200 Date: Thu, 17 Jun 2021 14:27:37 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: Thomas Schwinge , Richard Biener , Sandra Loosemore , gcc-patches Subject: Re: [Patch] Add 'default' to -foffload=; document that flag [PR67300] Message-ID: <20210617122737.GE7746@tucnak> Reply-To: Jakub Jelinek References: <1587c151-b99f-2f44-3044-7b01c296b9ad@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <1587c151-b99f-2f44-3044-7b01c296b9ad@codesourcery.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2021 12:27:46 -0000 On Thu, Jun 17, 2021 at 02:08:07PM +0200, Tobias Burnus wrote: > +@item -foffload=@var{offload-target-triplet} > +@itemx -foffload=@var{offload-target-triplet}=@var{flags} > +@itemx -foffload=@var{flags} > +@opindex foffload > +@cindex Offloading > +@cindex OpenACC > +@cindex OpenMP > +Specifies for which offload/non-host/accelerator devices code should > +be generated when using OpenACC (@option{-fopenacc}) -- or OpenMP > +(@option{-fopenmp}) with target regions. It additionally permits to > +pass arguments to the offload-target compiler. Note that code compiled > +for one or more offload-target devices can still be executable when some > +or all offload device are unavailable at runtime, in line with and as > +specified by the OpenACC and OpenMP specifications. I think default is not offload-target-triplet, so either we should rename the @var and then say that it is either offload-target-triplet or @code{default} or @code{disable}, or we should list those default and disable cases above as separate @itemx. > --- a/gcc/gcc.c > +++ b/gcc/gcc.c > @@ -4015,6 +4015,13 @@ handle_foffload_option (const char *arg) > break; > } > > + if (strcmp (target, "default") == 0) > + { > + free (offload_targets); > + offload_targets = xstrdup (OFFLOAD_TARGETS); > + break; > + } > + How does this interact with --enable-offload-defaulted ? Won't -fopenmp=default=-lm force in all configured targets even when say nvptx-none mkoffload/offloading compiler is missing? And how does it interact with previous -foffload=? I mean, -foffload=nvptx-none=-latomic -foffload=default=-lm Jakub