Re: [Patch] Add 'default' to -foffload=; document that flag [PR67300]

[Jakub Jelinek <jakub@redhat.com>]

On Thu, Jun 17, 2021 at 11:41:39AM -0600, Sandra Loosemore wrote:
> On 6/17/21 10:03 AM, Tobias Burnus wrote:
> 
> > Updated version – only lightly tested.  I think it is
> > consistent like that and the documentation should now be
> > comprehensive.  (I will have to do some additional testing.)
> > 
> > Further comments and thoughts?
> 
> Hmmm, I had started to put together some comments on
> grammar/punctuation/markup on the first version before the second iteration
> showed up in my mailbox, but more critically I could not figure out whether
> -foffload=default is supposed to be exactly identical to the default
> behavior; if it isn't, it should be, or -foffload=default ought to be
> renamed.  So let's get that sorted out first.  I suggest reorganizing the

Yeah.  If we want for --enable-offload-default also all configured targets,
we could add another keyword for it (all), but I'm not sure it would be
useful, because whenever it would be different from default it would mean
the linking would fail because one or more offloading targets that were
configured isn't supported (installed).

We need to figure out what it means -foffload=nvptx-none -foffload=default,
if the latter overrides the former (as if it wasn't specified), or if it
adds all the remaining offload targets that are default in addition to it.
And similarly figure out what happens with the optional flags, if they are
gathered from all the -foffload= options that refer to a particular target,
or taken from the last -foffload option that mentions that target, something
else.

	Jakub