From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id B189D3847805 for ; Thu, 17 Jun 2021 17:51:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B189D3847805 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-462-OuodACFdPzKikzQW3YJtvQ-1; Thu, 17 Jun 2021 13:51:00 -0400 X-MC-Unique: OuodACFdPzKikzQW3YJtvQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CC4F9800C60; Thu, 17 Jun 2021 17:50:58 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-115-161.ams2.redhat.com [10.36.115.161]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5CF105C1D1; Thu, 17 Jun 2021 17:50:58 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 15HHotgc079461 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 17 Jun 2021 19:50:55 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 15HHosql079460; Thu, 17 Jun 2021 19:50:54 +0200 Date: Thu, 17 Jun 2021 19:50:54 +0200 From: Jakub Jelinek To: Sandra Loosemore Cc: Tobias Burnus , Richard Biener , gcc-patches , Thomas Schwinge Subject: Re: [Patch] Add 'default' to -foffload=; document that flag [PR67300] Message-ID: <20210617175054.GI7746@tucnak> Reply-To: Jakub Jelinek References: <1587c151-b99f-2f44-3044-7b01c296b9ad@codesourcery.com> <20210617122737.GE7746@tucnak> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2021 17:51:04 -0000 On Thu, Jun 17, 2021 at 11:41:39AM -0600, Sandra Loosemore wrote: > On 6/17/21 10:03 AM, Tobias Burnus wrote: > > > Updated version – only lightly tested.  I think it is > > consistent like that and the documentation should now be > > comprehensive.  (I will have to do some additional testing.) > > > > Further comments and thoughts? > > Hmmm, I had started to put together some comments on > grammar/punctuation/markup on the first version before the second iteration > showed up in my mailbox, but more critically I could not figure out whether > -foffload=default is supposed to be exactly identical to the default > behavior; if it isn't, it should be, or -foffload=default ought to be > renamed. So let's get that sorted out first. I suggest reorganizing the Yeah. If we want for --enable-offload-default also all configured targets, we could add another keyword for it (all), but I'm not sure it would be useful, because whenever it would be different from default it would mean the linking would fail because one or more offloading targets that were configured isn't supported (installed). We need to figure out what it means -foffload=nvptx-none -foffload=default, if the latter overrides the former (as if it wasn't specified), or if it adds all the remaining offload targets that are default in addition to it. And similarly figure out what happens with the optional flags, if they are gathered from all the -foffload= options that refer to a particular target, or taken from the last -foffload option that mentions that target, something else. Jakub