From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 2A0D9398A875 for ; Thu, 17 Jun 2021 19:24:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2A0D9398A875 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15HJ4FA6031813; Thu, 17 Jun 2021 15:24:05 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 398bkvss66-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Jun 2021 15:24:05 -0400 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 15HJ4OLM034457; Thu, 17 Jun 2021 15:24:05 -0400 Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com with ESMTP id 398bkvss5w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Jun 2021 15:24:05 -0400 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 15HJGZUx003365; Thu, 17 Jun 2021 19:24:04 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma04wdc.us.ibm.com with ESMTP id 394mja3fyt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Jun 2021 19:24:04 +0000 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 15HJO4O839518570 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Jun 2021 19:24:04 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 42038AE062; Thu, 17 Jun 2021 19:24:04 +0000 (GMT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C0F99AE063; Thu, 17 Jun 2021 19:24:03 +0000 (GMT) Received: from ibm-toto.the-meissners.org (unknown [9.160.61.169]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTPS; Thu, 17 Jun 2021 19:24:03 +0000 (GMT) Date: Thu, 17 Jun 2021 15:24:02 -0400 From: Michael Meissner To: Segher Boessenkool Cc: Michael Meissner , gcc-patches@gcc.gnu.org, David Edelsohn , Bill Schmidt , Peter Bergner , Will Schmidt Subject: Re: [PATCH 2/3] Fix IEEE 128-bit min/max test. Message-ID: <20210617192402.GB30801@ibm-toto.the-meissners.org> Mail-Followup-To: Michael Meissner , Segher Boessenkool , gcc-patches@gcc.gnu.org, David Edelsohn , Bill Schmidt , Peter Bergner , Will Schmidt References: <20210609001744.GA16932@ibm-toto.the-meissners.org> <20210609002240.GB18854@ibm-toto.the-meissners.org> <20210617181158.GQ5077@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210617181158.GQ5077@gate.crashing.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: vze7XKZIFzG2QhHqDEmh0l0vuVgO1N9r X-Proofpoint-GUID: 3KBma_Vp7sef6v9VU42rdudBUU3tXz_H X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-06-17_15:2021-06-15, 2021-06-17 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 mlxscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106170118 X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2021 19:24:07 -0000 On Thu, Jun 17, 2021 at 01:11:58PM -0500, Segher Boessenkool wrote: > On Tue, Jun 08, 2021 at 08:22:40PM -0400, Michael Meissner wrote: > > > > * gcc.target/powerpc/float128-minmax.c: Adjust expected code for > > power10. > > * lib/target-supports.exp (check_effective_target_has_arch_pwr10): > > New target support. > > --- > > gcc/testsuite/gcc.target/powerpc/float128-minmax.c | 8 +++++--- > > gcc/testsuite/lib/target-supports.exp | 10 ++++++++++ > > 2 files changed, 15 insertions(+), 3 deletions(-) > > > > diff --git a/gcc/testsuite/gcc.target/powerpc/float128-minmax.c b/gcc/testsuite/gcc.target/powerpc/float128-minmax.c > > index fe397518f2f..a7d3a3a0b3e 100644 > > --- a/gcc/testsuite/gcc.target/powerpc/float128-minmax.c > > +++ b/gcc/testsuite/gcc.target/powerpc/float128-minmax.c > > @@ -1,6 +1,5 @@ > > -/* { dg-do compile { target lp64 } } */ > > Does that work? Why was it there before? > > > /* { dg-require-effective-target powerpc_p9vector_ok } */ > > -/* { dg-require-effective-target float128 } */ > > +/* { dg-require-effective-target ppc_float128_hw } */ > > Why is it okay to no longer run this test where it ran before? I was just being more precise. > > -/* { dg-final { scan-assembler {\mxscmpuqp\M} } } */ > > +/* Adjust code power10 which has native min/max instructions. */ > > +/* { dg-final { scan-assembler {\mxscmpuqp\M} { target { ! has_arch_pwr10 } } } } */ > > You need scan-assembler-times here? (Not that it had that before this > patch, of course). I can change it to scan-assembler-times. > > +/* { dg-final { scan-assembler {\mxsmincqp\M} { target { has_arch_pwr10 } } } } */ > > +/* { dg-final { scan-assembler {\mxsmaxcqp\M} { target { has_arch_pwr10 } } } } */ > > You can write just { target has_arch_pwr10 } here, I think? Please do > so (if that works, I haven't actually tested it :-) ) I thought so originally, but it didn't like it, so I added the extra {}'s. But I can try it again. -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meissner@linux.ibm.com, phone: +1 (978) 899-4797