public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Richard Biener <richard.guenther@gmail.com>,
	Jonathan Wakely <jwakely@redhat.com>
Cc: Martin Sebor <msebor@gmail.com>,
	Trevor Saunders <tbsaunde@tbsaunde.org>,
	 Richard Biener via Gcc-patches <gcc-patches@gcc.gnu.org>,
	Richard Sandiford <richard.sandiford@arm.com>
Subject: Re: [PATCH 5/6] make get_domminated_by_region return a auto_vec
Date: Fri, 18 Jun 2021 12:53:54 +0200	[thread overview]
Message-ID: <20210618105354.GM7746@tucnak> (raw)
In-Reply-To: <CAFiYyc3q-V1DBjOSFRVZkdW2vG93fyCYUAeS1KAZGjGX4C9yzQ@mail.gmail.com>

On Fri, Jun 18, 2021 at 12:38:09PM +0200, Richard Biener via Gcc-patches wrote:
> > Yes, as we discussed in the review below, vec is not a good model
> > because (as you note again above) it's constrained by its legacy
> > uses.  The best I think we can do for it is to make it safer to
> > use.
> > https://gcc.gnu.org/pipermail/gcc-patches/2021-June/571622.html
> 
> Which is what Trevors patches do by simply disallowing things
> that do not work at the moment.

I only see
  // You probably don't want to copy a vector, so these are deleted to prevent
  // unintentional use.  If you really need a copy of the vectors contents you
  // can use copy ().
  auto_vec(const auto_vec &) = delete;
  auto_vec &operator= (const auto_vec &) = delete;
on the
template<typename T>
class auto_vec<T, 0> : public vec<T, va_heap>
specialization, but not on the
template<typename T, size_t N = 0>
class auto_vec : public vec<T, va_heap>
template itself.  Shouldn't that one have also the deleted
copy ctor/assignment operator and in addition to that maybe deleted
move ctor/move assignment operator?

	Jakub


  reply	other threads:[~2021-06-18 10:54 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15  5:59 [PATCH 1/6] auto_vec copy/move improvements Trevor Saunders
2021-06-15  5:59 ` [PATCH 2/6] return auto_vec from cgraph_node::collect_callers Trevor Saunders
2021-06-15  6:45   ` Richard Biener
2021-06-15  5:59 ` [PATCH 3/6] return auto_vec from get_loop_hot_path Trevor Saunders
2021-06-15  6:45   ` Richard Biener
2021-06-17 13:48     ` Christophe Lyon
2021-06-17 14:41       ` Trevor Saunders
2021-06-17 18:34         ` Christophe Lyon
2021-06-15  5:59 ` [PATCH 4/6] return auto_vec from get_dominated_by Trevor Saunders
2021-06-15  6:46   ` Richard Biener
2021-06-15 11:18     ` Bernhard Reutner-Fischer
2021-06-16  3:09       ` Trevor Saunders
2021-06-16  5:45         ` Bernhard Reutner-Fischer
2021-06-17  6:56           ` Trevor Saunders
2021-06-15  5:59 ` [PATCH 5/6] make get_domminated_by_region return a auto_vec Trevor Saunders
2021-06-15  6:49   ` Richard Biener
2021-06-16 12:46     ` Richard Sandiford
2021-06-16 16:01       ` Martin Sebor
2021-06-17  6:03         ` Richard Biener
2021-06-17  8:23           ` Trevor Saunders
2021-06-17 14:43           ` Martin Sebor
2021-06-18 10:38             ` Richard Biener
2021-06-18 10:53               ` Jakub Jelinek [this message]
2021-06-18 11:03                 ` Jonathan Wakely
2021-06-18 11:04                   ` Jonathan Wakely
2021-06-18 16:03               ` Martin Sebor
2021-06-21  7:15                 ` Richard Biener
2021-06-22 20:01                   ` Martin Sebor
2021-06-23  5:23                     ` Trevor Saunders
2021-06-23  7:43                       ` Richard Biener
2021-06-23 10:22                         ` Richard Sandiford
2021-06-24  9:20                           ` Richard Biener
2021-06-24 16:28                             ` Richard Sandiford
2021-06-25  8:29                               ` Richard Biener
2021-06-23 22:56                         ` Martin Sebor
2021-06-24  9:27                           ` Richard Biener
2021-06-24 15:01                             ` Martin Sebor
2021-06-23 23:43                       ` Martin Sebor
2021-06-28  7:01                         ` Trevor Saunders
2021-06-15  5:59 ` [PATCH 6/6] return auto_vec from more dominance functions Trevor Saunders
2021-06-15  6:50   ` Richard Biener
2021-06-15  6:42 ` [PATCH 1/6] auto_vec copy/move improvements Richard Biener
2021-06-15  7:04   ` Trevor Saunders
2021-06-15  7:11     ` Richard Biener
2021-06-15  7:57       ` Trevor Saunders
2021-06-15  9:36         ` Richard Biener
2021-06-16  3:17           ` [PATCH, V2] " Trevor Saunders
2021-06-16 10:13             ` Richard Biener
2021-06-16 17:01               ` Martin Sebor
2021-06-15 16:18 ` [PATCH 1/6] " Martin Sebor
2021-06-16  3:31   ` Trevor Saunders

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210618105354.GM7746@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    --cc=msebor@gmail.com \
    --cc=richard.guenther@gmail.com \
    --cc=richard.sandiford@arm.com \
    --cc=tbsaunde@tbsaunde.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).