From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 47C5E3951894 for ; Tue, 22 Jun 2021 18:57:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 47C5E3951894 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 15MIu3QD008674; Tue, 22 Jun 2021 13:56:03 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 15MIu2jd008673; Tue, 22 Jun 2021 13:56:02 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Tue, 22 Jun 2021 13:56:02 -0500 From: Segher Boessenkool To: "Kewen.Lin" Cc: GCC Patches , David Edelsohn , Bill Schmidt , will schmidt , cel@us.ibm.com Subject: Re: rs6000: Fix typos in float128 ISA3.1 support Message-ID: <20210622185602.GD5077@gate.crashing.org> References: <32c02216-9f50-8b1b-9d5d-43a769c3c149@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <32c02216-9f50-8b1b-9d5d-43a769c3c149@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, TXREP, T_SPF_HELO_PERMERROR, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jun 2021 18:57:11 -0000 Hi! On Mon, Jun 21, 2021 at 05:27:06PM +0800, Kewen.Lin wrote: > Recently if we build gcc on Power with the assembler which doesn't > have Power10 support, the build will fail when building libgcc with > one error message like: > > Error: invalid switch -mpower10 > Error: unrecognized option -mpower10 > make[2]: *** [...gcc/gcc-base/libgcc/shared-object.mk:14: float128-p10.o] Error 1 In general, it is recommended to use a binutils of approximately the same age as the GCC you are trying to build. This is similar to us not supporting most other non-sensical configurations. An important reason for that is it cannot ever be tested, there are just too many strange combinations possible. That said :-) > By checking the culprit commit r12-1340, it's caused by some typos. (That is 9090f4807161.) > - fix test case used for libgcc_cv_powerpc_3_1_float128_hw check. I was confused here for a bit, "test case" usually means something in testsuite/, I'd call this just "test" :-) > BTW, there are some noises during regression testings due to > newer versions binutils, but they were identified as unrelated > after some checkings. Hrm, what kind of noise? > * config/rs6000/t-float128-hw(fp128_3_1_hw_funcs, > fp128_3_1_hw_src, fp128_3_1_hw_static_obj, fp128_3_1_hw_shared_obj, > fp128_3_1_hw_obj): Remove variables for ISA 3.1 support. Needs a space before the opening paren. Doesn't need a line break so early on that line btw. Just "Remove." or "Delete." is less confusing btw: what you wrote can be read as "Remove the variables from these declarations" or similar. And of course terseness is usually best in a changelog. > * config/rs6000/t-float128-p10-hw (FLOAT128_HW_INSNS): Append > macro FLOAT128_HW_INSNS_ISA3_1 for ISA 3.1 support. Don't say what it is for, just say what changed :-) > (FP128_3_1_CFLAGS_HW): Fix option typo. > * config/rs6000/float128-ifunc.c (SW_OR_HW_ISA3_1): Guarded > with FLOAT128_HW_INSNS_ISA3_1. "Guard", not "Guarded", all entries are written in the imperative, like, "Do this" or "Guard that". > +#ifdef FLOAT128_HW_INSNS_ISA3_1 > TFtype __floattikf (TItype_ppc) > __attribute__ ((__ifunc__ ("__floattikf_resolve"))); I wonder if we now need TItype_ppc at all anymore, btw? Okay for trunk with the changelog slightly massaged. Thanks! Segher