From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
David Edelsohn <dje.gcc@gmail.com>,
Bill Schmidt <wschmidt@linux.ibm.com>,
will schmidt <will_schmidt@vnet.ibm.com>,
cel@us.ibm.com, Michael Meissner <meissner@linux.ibm.com>
Subject: Re: [EXTERNAL] Re: rs6000: Fix typos in float128 ISA3.1 support
Date: Thu, 24 Jun 2021 14:36:53 -0500 [thread overview]
Message-ID: <20210624193653.GK5077@gate.crashing.org> (raw)
In-Reply-To: <675c530f-13dc-df82-cfd1-dd4b07e4a546@linux.ibm.com>
On Thu, Jun 24, 2021 at 05:32:20PM +0800, Kewen.Lin wrote:
> on 2021/6/24 上午12:58, Segher Boessenkool wrote:
> > On Wed, Jun 23, 2021 at 12:17:07PM +0800, Kewen.Lin wrote:
> >>>> +#ifdef FLOAT128_HW_INSNS_ISA3_1
> >>>> TFtype __floattikf (TItype_ppc)
> >>>> __attribute__ ((__ifunc__ ("__floattikf_resolve")));
> >>>
> >>> I wonder if we now need TItype_ppc at all anymore, btw?
> >>
> >> Sorry that I don't quite follow this question.
> >
> > I thought it may do the same as just TItype now, but the ifunc stuff
> > probably makes it different still :-)
>
> Ah, thanks for the clarification! If I read it right, TItype is defined
> with __attribute__ ((mode (TI))) while TItype_ppc is defined with
> __attribute__ ((__mode__ (__TI__))), the later writing looks special.
I managed to read things wrong, I thought there was some ifunc stuff in
the definition of TItype_ppc. Of course there is not, it is just
setting the mode.
mode(__TI__) is just the more portable way of writing mode(TI), the
latter will not work if something #define's TI (you cannot do that with
__TI__, you are not allowed to by the C standard, in application code).
So it looks like we could just use {U,}TItype here, no _ppc. Carl, is
there some reason I'm not seeing you used it?
Segher
next prev parent reply other threads:[~2021-06-24 19:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 9:27 Kewen.Lin
2021-06-22 18:56 ` Segher Boessenkool
2021-06-23 4:17 ` [EXTERNAL] " Kewen.Lin
2021-06-23 16:58 ` Segher Boessenkool
2021-06-24 9:32 ` Kewen.Lin
2021-06-24 19:36 ` Segher Boessenkool [this message]
2021-06-28 8:15 ` Kewen.Lin
2021-06-28 10:22 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210624193653.GK5077@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=cel@us.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=meissner@linux.ibm.com \
--cc=will_schmidt@vnet.ibm.com \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).