From: Robin Dapp <rdapp@linux.ibm.com>
To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com
Subject: [PATCH 5/7] ifcvt: Try re-using CC for conditional moves.
Date: Fri, 25 Jun 2021 18:09:03 +0200 [thread overview]
Message-ID: <20210625160905.23786-6-rdapp@linux.ibm.com> (raw)
In-Reply-To: <20210625160905.23786-1-rdapp@linux.ibm.com>
Following up on the previous patch, this patch makes
noce_convert_multiple emit two cmov sequences: The same one as before
and a second one that tries to re-use the existing CC. Then their costs
are compared and the cheaper one is selected.
---
gcc/ifcvt.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++++-----
1 file changed, 86 insertions(+), 8 deletions(-)
diff --git a/gcc/ifcvt.c b/gcc/ifcvt.c
index c5b8641e2aa..55405ce9ef7 100644
--- a/gcc/ifcvt.c
+++ b/gcc/ifcvt.c
@@ -3142,6 +3142,47 @@ bb_valid_for_noce_process_p (basic_block test_bb, rtx cond,
return false;
}
+/* Helper function to emit a cmov sequence. */
+
+static rtx_insn*
+try_emit_cmove_seq (struct noce_if_info *if_info, rtx temp,
+ rtx cond, rtx target,
+ rtx new_val, rtx old_val, bool need_cmov,
+ unsigned *cost, rtx *temp_dest,
+ rtx cc_cmp = NULL, rtx rev_cc_cmp = NULL)
+{
+ rtx_insn *seq = NULL;
+ *cost = 0;
+
+ rtx x = XEXP (cond, 0);
+ rtx y = XEXP (cond, 1);
+ rtx_code cond_code = GET_CODE (cond);
+
+ start_sequence ();
+
+ if (need_cmov)
+ *temp_dest = noce_emit_cmove (if_info, temp, cond_code,
+ x, y, new_val, old_val, cc_cmp, rev_cc_cmp);
+ else
+ {
+ *temp_dest = target;
+ if (if_info->then_else_reversed)
+ noce_emit_move_insn (target, old_val);
+ else
+ noce_emit_move_insn (target, new_val);
+ }
+
+ if (*temp_dest != NULL_RTX)
+ {
+ seq = get_insns ();
+ *cost = seq_cost (seq, if_info->speed_p);
+ }
+
+ end_sequence ();
+
+ return seq;
+}
+
/* We have something like:
if (x > y)
@@ -3199,7 +3240,9 @@ noce_convert_multiple_sets (struct noce_if_info *if_info)
rtx cond = noce_get_condition (jump, &cond_earliest, false);
rtx x = XEXP (cond, 0);
rtx y = XEXP (cond, 1);
- rtx_code cond_code = GET_CODE (cond);
+
+ rtx cc_cmp = cond_exec_get_condition (jump);
+ rtx rev_cc_cmp = noce_get_condition (jump, &cond_earliest, true);
/* The true targets for a conditional move. */
auto_vec<rtx> targets;
@@ -3301,18 +3344,52 @@ noce_convert_multiple_sets (struct noce_if_info *if_info)
old_val = lowpart_subreg (dst_mode, old_val, src_mode);
}
- /* Actually emit the conditional move. */
- rtx temp_dest = noce_emit_cmove (if_info, temp, cond_code,
- x, y, new_val, old_val);
+ /* Try emitting a conditional move passing the backend the
+ canonicalized comparison. The backend is then able to
+ recognize expressions like
- /* If we failed to expand the conditional move, drop out and don't
- try to continue. */
- if (temp_dest == NULL_RTX)
+ if (x > y)
+ y = x;
+
+ as min/max emit an insn, accordingly.
+ We will still emit a superfluous CC comparison before the
+ min/max, though, which complicates costing. */
+ unsigned cost1 = 0, cost2 = 0;
+ rtx_insn *seq, *seq1, *seq2;
+ rtx temp_dest = NULL_RTX, temp_dest1 = NULL_RTX, temp_dest2 = NULL_RTX;
+
+ seq1 = try_emit_cmove_seq (if_info, temp, cond, target,
+ new_val, old_val, need_cmov, &cost1, &temp_dest1);
+
+ /* Here, we try to pass the backend a non-canonicalized cc comparison
+ as well. This allows the backend to emit a cmov directly without
+ creating an additional compare for each. If successful, costing
+ is easier and this sequence is usually preferred. */
+ seq2 = try_emit_cmove_seq (if_info, target, cond, target,
+ new_val, old_val, need_cmov, &cost2, &temp_dest2,
+ cc_cmp, rev_cc_cmp);
+
+ /* Check which version is less expensive. */
+ if (seq1 != NULL_RTX && cost1 <= cost2)
+ {
+ seq = seq1;
+ temp_dest = temp_dest1;
+ }
+ else if (seq2 != NULL_RTX)
+ {
+ seq = seq2;
+ temp_dest = temp_dest2;
+ }
+ else
{
+ /* Nothing worked, bail out. */
end_sequence ();
return FALSE;
}
+ /* End the sub sequence and emit to the main sequence. */
+ emit_insn (seq);
+
/* Bookkeeping. */
count++;
targets.safe_push (target);
@@ -3326,7 +3403,8 @@ noce_convert_multiple_sets (struct noce_if_info *if_info)
/* Now fixup the assignments. */
for (int i = 0; i < count; i++)
- noce_emit_move_insn (targets[i], temporaries[i]);
+ if (targets[i] != temporaries[i])
+ noce_emit_move_insn (targets[i], temporaries[i]);
/* Actually emit the sequence if it isn't too expensive. */
rtx_insn *seq = get_insns ();
--
2.31.1
next prev parent reply other threads:[~2021-06-25 16:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 16:08 [PATCH 0/7] ifcvt: Convert multiple Robin Dapp
2021-06-25 16:08 ` [PATCH 1/7] ifcvt: Check if cmovs are needed Robin Dapp
2021-07-15 20:10 ` Richard Sandiford
2021-07-22 12:06 ` Robin Dapp
2021-07-26 19:08 ` Richard Sandiford
2021-09-15 8:39 ` Robin Dapp
2021-10-14 8:45 ` Richard Sandiford
2021-10-14 14:20 ` Robin Dapp
2021-10-14 14:32 ` Richard Sandiford
2021-10-18 11:40 ` Robin Dapp
2021-11-03 8:55 ` Robin Dapp
2021-11-05 15:33 ` Richard Sandiford
2021-11-12 13:00 ` Robin Dapp
2021-11-30 16:36 ` Richard Sandiford
2021-06-25 16:09 ` [PATCH 2/7] ifcvt: Allow constants for noce_convert_multiple Robin Dapp
2021-07-15 20:25 ` Richard Sandiford
2021-06-25 16:09 ` [PATCH 3/7] ifcvt: Improve costs handling " Robin Dapp
2021-07-15 20:42 ` Richard Sandiford
2021-07-22 12:07 ` Robin Dapp
2021-07-26 19:10 ` Richard Sandiford
2021-06-25 16:09 ` [PATCH 4/7] ifcvt/optabs: Allow using a CC comparison for emit_conditional_move Robin Dapp
2021-07-15 20:54 ` Richard Sandiford
2021-07-22 12:07 ` Robin Dapp
2021-07-26 19:31 ` Richard Sandiford
2021-07-27 20:49 ` Robin Dapp
2021-08-06 12:14 ` Richard Sandiford
2021-06-25 16:09 ` Robin Dapp [this message]
2021-07-22 12:12 ` [PATCH 5/7] ifcvt: Try re-using CC for conditional moves Robin Dapp
2021-06-25 16:09 ` [PATCH 6/7] testsuite/s390: Add tests for noce_convert_multiple Robin Dapp
2021-06-25 16:09 ` [PATCH 7/7] s390: Increase costs for load on condition and change movqicc expander Robin Dapp
2021-07-13 12:42 ` [PATCH 0/7] ifcvt: Convert multiple Robin Dapp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210625160905.23786-6-rdapp@linux.ibm.com \
--to=rdapp@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).