public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
	David Edelsohn <dje.gcc@gmail.com>,
	 Bill Schmidt <wschmidt@linux.ibm.com>,
	will schmidt <will_schmidt@vnet.ibm.com>,
	cel@us.ibm.com, Michael Meissner <meissner@linux.ibm.com>
Subject: Re: [EXTERNAL] Re: rs6000: Fix typos in float128 ISA3.1 support
Date: Mon, 28 Jun 2021 05:22:44 -0500	[thread overview]
Message-ID: <20210628102244.GB668@gate.crashing.org> (raw)
In-Reply-To: <766cae11-b4f1-b705-587d-e2d35d91cde4@linux.ibm.com>

On Mon, Jun 28, 2021 at 04:15:15PM +0800, Kewen.Lin wrote:
> on 2021/6/25 上午3:36, Segher Boessenkool wrote:
> > mode(__TI__) is just the more portable way of writing mode(TI), the
> > latter will not work if something #define's TI (you cannot do that with
> > __TI__, you are not allowed to by the C standard, in application code).
> 
> Yeah, thanks for the note.  It looks better to update the generic
> macro with this ppc style "__" writting and remove ppc one. :-)
> 
> One related bug PR101235 was just opened, I noticed the culprit commit
> was backported to GCC11, is it OK to backport this fix to GCC 11 if
> everything goes well in one more week?

Please backport this immediately.  Thanks!


Segher

      reply	other threads:[~2021-06-28 10:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21  9:27 Kewen.Lin
2021-06-22 18:56 ` Segher Boessenkool
2021-06-23  4:17   ` [EXTERNAL] " Kewen.Lin
2021-06-23 16:58     ` Segher Boessenkool
2021-06-24  9:32       ` Kewen.Lin
2021-06-24 19:36         ` Segher Boessenkool
2021-06-28  8:15           ` Kewen.Lin
2021-06-28 10:22             ` Segher Boessenkool [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210628102244.GB668@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=cel@us.ibm.com \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=linkw@linux.ibm.com \
    --cc=meissner@linux.ibm.com \
    --cc=will_schmidt@vnet.ibm.com \
    --cc=wschmidt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).