public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Alan Modra <amodra@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [RS6000] Adjust testcases for power10 instructions
Date: Thu, 1 Jul 2021 16:47:21 -0500	[thread overview]
Message-ID: <20210701214721.GF1583@gate.crashing.org> (raw)
In-Reply-To: <YN3DK4wVAAUqIapW@squeak.grove.modra.org>

Hi!

On Thu, Jul 01, 2021 at 10:59:15PM +0930, Alan Modra wrote:
> 	* lib/target-supports.exp (check_effective_target_has_arch_pwr10): New.

Mike added this already, please make sure to not add it twice :-)

[...]
> 	gcc.target/powerpc/pr86731-fwrapv-longlong.c: Match power10 insns.

(It still allows older as well, so "Also match" maybe?)

Did you make sure all of these are correct and expected?  Are the
testcases still strict enough, or should you add -mno-pcrel to the
options, instead?  Or maybe test both -mpcrel and -mno-pcrel?  Etc.

> 	* gcc.target/powerpc/lvsl-lvsr.c: Avoid file name match.

You also add a "p?", is that expected?  Should be in the changelog
then :-)

> -/* { dg-final { scan-assembler-times {\mlxvd2x\M|\mlxv\M} 2 } } */
> +/* { dg-final { scan-assembler-times {\mlxvd2x\M|\mp?lxv\M} 2 } } */


> @@ -1,12 +1,12 @@
>  /* Test expected code generation for lvsl and lvsr on little endian.
> -   Note that lvsl and lvsr are each produced once, but the filename
> -   causes them to appear twice in the file.  */
> +   Note that \s is used in the lvsl/lvsr matches so we don't match
> +   on '.file "lvsl-lvsr.c"'.  */

Even better is to not put the instruction names in the filename, but
heh, maybe that would be too simple ;-)


Segher

  reply	other threads:[~2021-07-01 21:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01 13:29 Alan Modra
2021-07-01 21:47 ` Segher Boessenkool [this message]
2021-07-01 23:56   ` Alan Modra
  -- strict thread matches above, loose matches on Subject: below --
2020-10-22  7:03 Alan Modra
2020-10-22 12:55 ` Alan Modra
2020-10-23  6:15   ` Alan Modra
2020-10-23 18:22     ` Segher Boessenkool
2020-10-24  0:59       ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210701214721.GF1583@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=amodra@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).