public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Fangrui Song <i@maskray.me>
To: Kito Cheng <kito.cheng@sifive.com>
Cc: gcc-patches@gcc.gnu.org, kito.cheng@gmail.com, jimw@sifive.com
Subject: Re: [PATCH] docs: Add 'S' to Machine Constraints for RISC-V
Date: Wed, 7 Jul 2021 16:26:25 -0700	[thread overview]
Message-ID: <20210707232625.zntqg54rmxv6lj4n@gmail.com> (raw)
In-Reply-To: <20210702023010.53289-1-kito.cheng@sifive.com>

On 2021-07-02, Kito Cheng wrote:
>It was undocument before, but already used in linux kernel, so LLVM
>community suggest we should document that, so that make it become
>supported/documented/non-internal machine constraints.
>
>gcc/ChangeLog:
>
>	PR target/101275
>	* doc/md.text (Machine Constraints): Document the 'S' constraints
>	for RISC-V.
>---
> gcc/doc/md.texi | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi
>index 00caf3844cc..b776623e8a5 100644
>--- a/gcc/doc/md.texi
>+++ b/gcc/doc/md.texi
>@@ -3536,6 +3536,9 @@ A 5-bit unsigned immediate for CSR access instructions.
> @item A
> An address that is held in a general-purpose register.
>
>+@item S
>+A constant call address.
>+
> @end table
>
> @item RX---@file{config/rx/constraints.md}
>-- 
>2.31.1
>

Ping on this:)

'S' can be used on either a variable or a function. Does "A constant call address." need change?

  parent reply	other threads:[~2021-07-07 23:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02  2:30 Kito Cheng
2021-07-02  3:15 ` Fangrui Song
2021-07-07 23:26 ` Fangrui Song [this message]
2021-07-08  1:02   ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210707232625.zntqg54rmxv6lj4n@gmail.com \
    --to=i@maskray.me \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jimw@sifive.com \
    --cc=kito.cheng@gmail.com \
    --cc=kito.cheng@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).