From: Jan Hubicka <hubicka@ucw.cz>
To: Martin Jambor <mjambor@suse.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] ipa-sra: Fix thinko when overriding safe_to_import_accesses (PR 101066)
Date: Thu, 8 Jul 2021 15:16:34 +0200 [thread overview]
Message-ID: <20210708131634.GA52801@kam.mff.cuni.cz> (raw)
In-Reply-To: <ri6y2b3dlgr.fsf@suse.cz>
Hi,
> 2021-06-16 Martin Jambor <mjambor@suse.cz>
>
> PR ipa/101066
> * ipa-sra.c (class isra_call_summary): New member
> m_before_any_store, initialize it in the constructor.
> (isra_call_summary::dump): Dump the new field.
> (ipa_sra_call_summaries::duplicate): Copy it.
> (process_scan_results): Set it.
> (isra_write_edge_summary): Stream it.
> (isra_read_edge_summary): Likewise.
> (param_splitting_across_edge): Only override
> safe_to_import_accesses if m_before_any_store is set.
>
> gcc/testsuite/ChangeLog:
>
> 2021-06-16 Martin Jambor <mjambor@suse.cz>
>
> PR ipa/101066
> * gcc.dg/ipa/pr101066.c: New test.
OK, thanks!
The analysis disabling transformation on any memory store is overly
conservative. We have pointer (which is a parameter and comes from
outer world) and no type infomration, however alias oracle will still be
able to disambiguate when memory access is to non-escaping local memory
or mallocated memory block etc.
Honza
prev parent reply other threads:[~2021-07-08 13:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 20:14 Martin Jambor
2021-07-02 9:50 ` Martin Jambor
2021-07-08 13:16 ` Jan Hubicka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210708131634.GA52801@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=mjambor@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).