From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Paul A. Clarke" <pc@us.ibm.com>
Cc: gcc-patches@gcc.gnu.org, Bill Schmidt <wschmidt@linux.ibm.com>
Subject: Re: [PATCH 1/4 committed] rs6000: Add support for SSE4.1 "test" intrinsics
Date: Tue, 13 Jul 2021 18:12:03 -0500 [thread overview]
Message-ID: <20210713231203.GX1583@gate.crashing.org> (raw)
In-Reply-To: <20210713190118.GB9282@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com>
On Tue, Jul 13, 2021 at 02:01:18PM -0500, Paul A. Clarke wrote:
> > > >+extern __inline int __attribute__((__gnu_inline__, __always_inline__,
> > > >__artificial__))
> > > Line too long, please fix here and below. (Existing cases can be left.)
> >
> > I wouldn't bother in this case. There is no way to write these
> > attribute lines in a reasonable way, it doesn't overflow 80 char by that
> > much, and there isn't anything interesting at the end of line.
>
> I bothered. ;-)
Ha :-)
Btw, Bill suggested to me offline making a preprocessor macro for this
long attribute line. Which is a fine suggestion! Something for the
future, maybe?
Segher
next prev parent reply other threads:[~2021-07-13 23:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 18:08 [PATCH 0/4] rs6000: Add SSE4.1 "test" and "blend" intrinsics Paul A. Clarke
2021-06-29 18:08 ` [PATCH 1/4] rs6000: Add support for SSE4.1 "test" intrinsics Paul A. Clarke
2021-07-11 15:45 ` Bill Schmidt
2021-07-12 22:24 ` Segher Boessenkool
2021-07-13 19:01 ` [PATCH 1/4 committed] " Paul A. Clarke
2021-07-13 23:12 ` Segher Boessenkool [this message]
2021-06-29 18:08 ` [PATCH 2/4] rs6000: Add tests " Paul A. Clarke
2021-07-11 15:49 ` Bill Schmidt
2021-07-12 22:39 ` Segher Boessenkool
2021-06-29 18:08 ` [PATCH 3/4] rs6000: Add support for SSE4.1 "blend" intrinsics Paul A. Clarke
2021-07-11 16:17 ` Bill Schmidt
2021-07-11 16:29 ` Bill Schmidt
2021-07-12 21:29 ` Paul A. Clarke
2021-06-29 18:08 ` [PATCH 4/4] rs6000: Add tests " Paul A. Clarke
2021-07-11 16:19 ` Bill Schmidt
2021-07-12 22:52 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713231203.GX1583@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=pc@us.ibm.com \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).