From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <segher@kernel.crashing.org>
Received: from gate.crashing.org (gate.crashing.org [63.228.1.57])
 by sourceware.org (Postfix) with ESMTP id 12DCC3857821
 for <gcc-patches@gcc.gnu.org>; Wed, 14 Jul 2021 22:59:54 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 12DCC3857821
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none)
 header.from=kernel.crashing.org
Authentication-Results: sourceware.org;
 spf=fail smtp.mailfrom=kernel.crashing.org
Received: from gate.crashing.org (localhost.localdomain [127.0.0.1])
 by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 16EMwrHE024835;
 Wed, 14 Jul 2021 17:58:53 -0500
Received: (from segher@localhost)
 by gate.crashing.org (8.14.1/8.14.1/Submit) id 16EMwq6u024834;
 Wed, 14 Jul 2021 17:58:52 -0500
X-Authentication-Warning: gate.crashing.org: segher set sender to
 segher@kernel.crashing.org using -f
Date: Wed, 14 Jul 2021 17:58:52 -0500
From: Segher Boessenkool <segher@kernel.crashing.org>
To: will schmidt <will_schmidt@vnet.ibm.com>
Cc: Bill Schmidt <wschmidt@linux.ibm.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 05/55] rs6000: Add helper functions for parsing
Message-ID: <20210714225852.GG1583@gate.crashing.org>
References: <cover.1623941441.git.wschmidt@linux.ibm.com>
 <643ab7459789d98707031c6081e686608030c864.1623941441.git.wschmidt@linux.ibm.com>
 <2f1d4550001868d94ef6a1dfd7c6eba3d86c4c87.camel@vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2f1d4550001868d94ef6a1dfd7c6eba3d86c4c87.camel@vnet.ibm.com>
User-Agent: Mutt/1.4.2.3i
X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, TXREP, T_SPF_HELO_PERMERROR,
 T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Jul 2021 22:59:55 -0000

Hi!

On Fri, Jul 09, 2021 at 02:32:59PM -0500, will schmidt wrote:
> On Thu, 2021-06-17 at 10:18 -0500, Bill Schmidt via Gcc-patches wrote:
> > 2021-06-07  Bill Schmidt  <wschmidt@linux.ibm.com>
> > +/* Pass over unprintable characters and whitespace (other than a newline,
> > +   which terminates the scan).  */

> > +static void
> > +consume_whitespace (void)
> > +{
> > +  while (pos < LINELEN && isspace(linebuf[pos]) && linebuf[pos] != '\n')
> > +    pos++;
> > +  return;
> > +}

> AFAIK isspace() and thusly this helper only skips whitespace, so
> nothing unprintable is actually handled or skipped here.

Right, and that behaviour would not match with the function name either.
isspace returns true for 0x09..0x0d and 0x20, all of which are
whitespace.


Segher