From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 3C020398CC03 for ; Wed, 14 Jul 2021 23:33:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3C020398CC03 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 16ENWUU1027835; Wed, 14 Jul 2021 18:32:30 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 16ENWU7o027833; Wed, 14 Jul 2021 18:32:30 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Wed, 14 Jul 2021 18:32:30 -0500 From: Segher Boessenkool To: Bill Schmidt Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 05/55] rs6000: Add helper functions for parsing Message-ID: <20210714233230.GH1583@gate.crashing.org> References: <643ab7459789d98707031c6081e686608030c864.1623941441.git.wschmidt@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <643ab7459789d98707031c6081e686608030c864.1623941441.git.wschmidt@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, TXREP, T_SPF_HELO_PERMERROR, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2021 23:33:33 -0000 Hi! On Thu, Jun 17, 2021 at 10:18:49AM -0500, Bill Schmidt wrote: > * config/rs6000/rs6000-gen-builtins.c (consume_whitespace): New > function. > (advance_line): Likewise. > (safe_inc_pos): Likewise. > (match_identifier): Likewise. > (match_integer): Likewise. > (match_to_right_bracket): Likewise. > +/* Pass over unprintable characters and whitespace (other than a newline, > + which terminates the scan). */ See Will's review :-) > + buf[lastpos - startpos + 1] = '\0'; Just "= 0"? It means exactly the same. You can write just diag ("bla bla bla") instead of (*diag) ("bla bla bla"); btw. The patch is okay for trunk with whatever you want to do with those comments (but do fix the consume_whitespace comment please). Thanks! Segher