From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2066.outbound.protection.outlook.com [40.107.21.66]) by sourceware.org (Postfix) with ESMTPS id 054B6398AC02 for ; Thu, 15 Jul 2021 16:41:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 054B6398AC02 Received: from DB6PR07CA0067.eurprd07.prod.outlook.com (2603:10a6:6:2a::29) by AM6PR08MB3080.eurprd08.prod.outlook.com (2603:10a6:209:4c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Thu, 15 Jul 2021 16:41:06 +0000 Received: from DB5EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2a:cafe::9d) by DB6PR07CA0067.outlook.office365.com (2603:10a6:6:2a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.10 via Frontend Transport; Thu, 15 Jul 2021 16:41:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT007.mail.protection.outlook.com (10.152.20.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Thu, 15 Jul 2021 16:41:06 +0000 Received: ("Tessian outbound bbfc4df8f27e:v99"); Thu, 15 Jul 2021 16:41:06 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 375439b476e59b12 X-CR-MTA-TID: 64aa7808 Received: from 95413094ded3.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2130D887-FE5F-4ACB-8E13-2CA33B14EFC3.1; Thu, 15 Jul 2021 16:40:52 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 95413094ded3.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 15 Jul 2021 16:40:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UOBHyTaEjk+2wxAzxxEYT/YNeaQZYzNni8jCtLahfybPkqQDBbNmkPAQjhx6GaxwuE9wxkVkQLnrhhpkBFBXoumHcxedUEEn8EGfDp3Z6yDYJADC2FeQIuct45P+3pqVYbLl9SHFYwfbUclSsIBP5IznAs5txFJ+7N5Fb95O2hJH7ge2xU8+1x9+EAL5WSCBPgD1d0QjNhG3pC7LjuWcNJ7I6mIGHH8eJZiQSc9Di3YfF22zLwBy6E159HsSGQi/eySJ8u2gqIEe/M1nSnOk2SSkhhsZ/RZEv54R1o5VjSY7rzxgZCudwIuxNCos6EmJoMlMrhKJ+Lsv86q7nH1UDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a3Dj6jZOXGw5qnLblgUPv3GWN4tmy9rBeLtwDoq0vqA=; b=DGoQRuqPCjkJLs/raqr+biMt00TbG69qagJX3ZVgnWah4K/RgslGLztUiQ24Q5QeYF9QqmAfhRfKZ2LZQbyjJ8rny81GY740/CWXI1qAJr/ZcFM5I2M8z8wUpg8qB/3Pn6TrEdFu1onOWN2Nj4LBm5LnIRLTj/yAaOBd8E6jtVVBavZMtAxdaNpOZWD3VtylDYYfQJdhaQFIEfAKoGchCIr3p5GyBG060t/kjD7WtSx1DSFhbM3aXOT2IQin6a8puSDpYI6hT8KLU2FvXzqXb0XZNjVjztxDV1V5wlejym26kAywnzmFTrCR4HWro+sVhFpuN+TvRokYviGln24IaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB5325.eurprd08.prod.outlook.com (2603:10a6:803:13e::17) by VI1PR0802MB2479.eurprd08.prod.outlook.com (2603:10a6:800:af::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.26; Thu, 15 Jul 2021 16:40:51 +0000 Received: from VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::cdbb:a6b9:e814:19c7]) by VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::cdbb:a6b9:e814:19c7%7]) with mapi id 15.20.4331.021; Thu, 15 Jul 2021 16:40:51 +0000 Date: Thu, 15 Jul 2021 17:40:49 +0100 From: Tamar Christina To: gcc-patches@gcc.gnu.org Cc: nd@arm.com, Ramana.Radhakrishnan@arm.com, Richard.Earnshaw@arm.com, nickc@redhat.com, Kyrylo.Tkachov@arm.com Subject: [PATCH 4/4][AArch32]: correct dot-product RTL patterns. Message-ID: <20210715164045.GA8025@arm.com> Content-Type: multipart/mixed; boundary="BXVAT5kNtrzKuDFl" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: LO2P265CA0176.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::20) To VI1PR08MB5325.eurprd08.prod.outlook.com (2603:10a6:803:13e::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.51) by LO2P265CA0176.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Thu, 15 Jul 2021 16:40:51 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0ccad5fc-76d5-44fe-9bf2-08d947af57c8 X-MS-TrafficTypeDiagnostic: VI1PR0802MB2479:|AM6PR08MB3080: X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0oZxnFifztRT21q2X1XKosyNtFXwkq88sCbjMyTkpyKC+T7qk6YZDpxxlZxB6XvIpLA52zVrPlvGY4meoCibghRn8IKy3qVYJvCVLoW3DmsKx+vRmljSfe2PUot7DZU8dgA3VS3eRPercuDyr8e5KtzRDZN/73W4TrIPxMvoQXhy6afnFOezA9QJzlSL33PhLFntcsd6G6q9Z6QFNkR3OCeF96uveA8CyThssFOIZ/kMccLI6QaxvUyFrqo4Pku0DpqhleUieW8fnSfBeZeLEahutoBUtD46YUf7a+3rfo/uqke9V4b+HvT8TQF3wio3kGlsLQABFCZAXD+dEjf0BBuDk21otSntskGX13g48Hmtg1bt4jCLlmEWaJh0h5y6Rvxfro/nc1AXgVNGsQhL6UxTZhzYo+/fHqioGmx6/TyQ+GDNwYYdIEPISzlYx56Zca/7xkQoUXmdG+5ZgQpNEt2cxlVIEONLhsm1wySo0sRvO5aMkVZALF8hVzEs2Ts6F+yFxk/KE8U4DRPZBtxKLuZLsM0HaVwXUbgO2DY5JworbwgBB/vs1GHl9P6yQzm/obWxlVeuWVD7GhEk90t/pLBEExzBv/qwmNd4OdW2WFkLuEa2aQnh6XDQoa681vdfiCRUUPy0tPIslPdj6YcwjdgOvYKE9nAkk8GZ/Ad3EbGjwaUAS4ZYMfTYJnO0FAwEI3lUgIl67LoQqMCjDjf4brKmxQRYW4yOE3uqKMJKMHY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB5325.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39860400002)(376002)(136003)(346002)(396003)(8676002)(66946007)(4326008)(66616009)(83380400001)(2906002)(66556008)(44832011)(316002)(8936002)(55016002)(36756003)(956004)(2616005)(66476007)(235185007)(6916009)(26005)(478600001)(38100700002)(5660300002)(1076003)(8886007)(86362001)(7696005)(4743002)(38350700002)(44144004)(33964004)(52116002)(186003)(33656002)(2700100001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzN5YVpEMjFuK2xMTno2M1FIdHlGZ0FjWFBWdmZKd2VWMlR1SXN0VGgyeTlZ?= =?utf-8?B?bnFlanNjeU5WbVM5ckEvYkl2QmFRUTlCU0hBR3M0aHVRM3pwaXJLT00xS3Ro?= =?utf-8?B?Z0IzZW9vQyttcTFLRGVpU1gxcGNGaGNwdzFhVUNldEZsSTBZcnhmMWdxM3dR?= =?utf-8?B?OU0vUWZqL0RGWUlrV3N1UTIzaitqZWp6Ri9SQklLTXpZZC9CUUdGdEZqV0hI?= =?utf-8?B?NXVzQ1FIY1RNZlU4RUFZZ05Zdm8wbkEwQ0xCK2hMV1RsaW5yb1lYNFhzWkcv?= =?utf-8?B?empkdFdCdkJVS2JvVXZyQlp2WURhUEExMDc4Ukowa3pvYjB6bmNTMk5seU5K?= =?utf-8?B?N0FFWTZ2ZnFZSUlTc2MwZWJBTkJWRys3Q1dLd2FaUWlUNkM0TldEcmxmdTFD?= =?utf-8?B?eFI5QUJKWmxHTU1jODJHczZhd2N6bTdsUi9kODM2a0puWWVxdzFYdk12eTc0?= =?utf-8?B?RnBXOHcyYkdVWnFNcEFjRDJpMy8zaXloSmJqdU5zVk1IWU9TallkSjBCa1hO?= =?utf-8?B?N0hjZWpwR1ArSjY2WEJpZnI2Zk5NemhZQUdLeDd3dXduLy82SnpHWFFFTUNh?= =?utf-8?B?K0M1N05nbzVueDVUcm9hejJyYnUvbHBWOFNFTFljdlNBVktSR0FRT0grYWdl?= =?utf-8?B?MWdYZng4aUJ6OXV3OUdnZ3diV0ZiT0JXUkxKK1ZlVjFHNXBvL3o5Rmw2OTJY?= =?utf-8?B?cWVvejVGeVB6UGUrOEUrOS9aTGZVU0RhTm45Z2NxRzhpcEdQTy9oVDdJOGsy?= =?utf-8?B?dUJqMG40VHVLTDFIbUJDc1lSOTJlY2pNUGl2OTNsZU43c2M1R1pOY1ZOdzJw?= =?utf-8?B?NUpvMEdKQkFaYy9Ebnc2VytTOVBLeXUzZ2laVUhGZVFEcE12WFRQNXo2RTln?= =?utf-8?B?c0ZhVkEwQW1DSzBNeHdBSUFqU21jWVJOZjlIWU9yM2c2WkVMTlhnSlF1Snpn?= =?utf-8?B?ZUFvVWR5R3JkT3hCcUZxaW5CcUhMMXMzYW4rWnplYjg5UHU4MTdsZU5OOG1V?= =?utf-8?B?ZXZjUUF5K2FlZlpzYVA1Mld6OWtkQkIzVXpBYXdKRzNBNDJPOFhWdFRTRDNl?= =?utf-8?B?bUFxeERQTyt0ZTdXVjFUalRKQ2JKdjd2SWpHMzdpTkNzeXdGSFBINEpUZkRz?= =?utf-8?B?eWZyemVaZXhiL2F6Sk0vYVVpMzhqQVBtbEJTaG5RUFBUQm9kdzBvSGs4bTV4?= =?utf-8?B?dFR6UzVrbU9jYlBSZ216UldPMllNTnFESGMrMWhDeEt6TDFjenBZdm9wck9D?= =?utf-8?B?TkJRbHlrbHZOTmM4cS81S1pMN2ZnN2FvR0JncmFkZnVQRXN3MzZqZFdtNjZB?= =?utf-8?B?N0NOSXRrYXEvZWxZTVRyc1VOMHlEQ1d0bjU2d2RWYTZhUEs5T0RqSUVTY1Ar?= =?utf-8?B?MDZyeUc4eXVrbEExMVdqajZqQ1R0ckVlbVE3dWpuZ1QzazJxY2pjS05qWkdj?= =?utf-8?B?dlZBMmUvK09OOVlIL3haQ2RkUjFyZE1ITUdscmpZdnNLUHJja0pxREdDd1d1?= =?utf-8?B?dDRyYVFRN05jWTM4d0dwTkpYZEpvNUtxMmVYRTZZNnB5NlFmT3lZMzB1N0NP?= =?utf-8?B?RHVWNWlBcENrMFczamNLTUV5MjFTT1BGSy9VSG0vRTlBcmRKSWNwQWh2TUgz?= =?utf-8?B?WU9kUnFoTG1qWUlGV2U5UmVZN09oZVdiNWJub0FwS3NhT0t2cE9RZW8rWVNr?= =?utf-8?B?K1JtNlFMWjl5UmhWRjVXeUJuZUNZSVZlcDUydldVamtEMExVRXJtS3RDWGlO?= =?utf-8?Q?gQ0ks3hfCwRQj/n0Zl19R3l21vxoV1vaGq0jHvs?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2479 Original-Authentication-Results: gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 46234e97-9ac3-4e60-5bbe-08d947af4ec1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s3rC7zACNkBukfcCnkOBa6Um+6voRhvDcNiBrAOnfxRcyK20q2ki9CzHzmquU4gtmNhVndjSu9nnx3NwMp5WvkBZJdU6R4i/etYScc+uGBtDqwlsPPOcTvhyzRUdSWIQ215AWkteLgvNUHrOX4GeTgOOZHbB2jZyTNIwV6BfIlh7RIRKzUdf5fpW4VTPKpDkHTOk6+asyvqUiUACCUS70QTTb2fD7vFY4R20b1TpxU5emeyChnCLkiVPLPWBZdDW/+ewu8+7AcSisql9r6hVi7diyTHJDvG7GNCGlVD4JE1+I+oeGnY2rlA1TgaQzQKA6e/2j9suX/HTAFJYK6jParmoPdKp+AJhn8V+zQDa4R0Z9DQp54KfvWiaKnxknyus6MJSv852TK/XfED06pS18mJbeRvfW2Eb0bZUAOeHv39ZW/4gtBzfM3b+XA/it0KGRQZPfJNCphBSfFXFn18Otg1RXSVjsLDpheRs2hRqcBMIkaGKinPBWqGizl9++aH+3L0YlTplM2WoPIatlBxS+PpOPmapfMjns92WlUjpK0Pm6nQEvWLZeqcuOcg1PP+NlVQQB5k3o53Btt+mEGPNAAVPm30O48HDMX1jl2QKadS2RPNBUlpyr0mAvQvFwnVuYBcctwXyKa74mOD8o3zIuPf2rZ7QPwD2CWnIFk1g9GgKq5e5iAJwhdqcth4TOxECQd9ysLpzEfWqjiAoUuT9nk78UdXqkUhIwr5JA2eNdog= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(346002)(136003)(39830400003)(376002)(46966006)(36840700001)(356005)(186003)(6916009)(70586007)(316002)(36860700001)(8936002)(44832011)(47076005)(83380400001)(33656002)(1076003)(2906002)(478600001)(82310400003)(7696005)(44144004)(33964004)(86362001)(81166007)(70206006)(2616005)(956004)(26005)(36756003)(4743002)(4326008)(8676002)(235185007)(8886007)(55016002)(5660300002)(336012)(66616009)(2700100001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2021 16:41:06.7169 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0ccad5fc-76d5-44fe-9bf2-08d947af57c8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3080 X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jul 2021 16:41:11 -0000 --BXVAT5kNtrzKuDFl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Hi All, The previous fix for this problem was wrong due to a subtle difference between where NEON expects the RMW values and where intrinsics expects them. The insn pattern is modeled after the intrinsics and so needs an expand for the vectorizer optab to switch the RTL. However operand[3] is not expected to be written to so the current pattern is bogus. Instead we use the expand to shuffle around the RTL. The vectorizer expects operands[3] and operands[0] to be the same but the aarch64 intrinsics expanders expect operands[0] and operands[1] to be the same. arm-none-linux-gnueabihf build is currently broken, the best I could do is verify on arm-none-eabi but the tests are all marked UNSUPPORTED, but the ICE is gone for the backend test. Ok for master? and active branches after some stew? Thanks, Tamar gcc/ChangeLog: * config/arm/neon.md (dot_prod): Correct RTL. --- inline copy of patch -- diff --git a/gcc/config/arm/neon.md b/gcc/config/arm/neon.md index 8b0a396947cc8e7345f178b926128d7224fb218a..876577fc20daee30ecdf03942c0d81c15bf8fe9a 100644 --- a/gcc/config/arm/neon.md +++ b/gcc/config/arm/neon.md @@ -2954,20 +2954,14 @@ (define_insn "neon_dot_lane" ;; and so the vectorizer provides r, in which the result has to be accumulated. (define_expand "dot_prod" [(set (match_operand:VCVTI 0 "register_operand") - (plus:VCVTI (unspec:VCVTI [(match_operand: 1 + (plus:VCVTI (match_operand:VCVTI 3 "register_operand") + (unspec:VCVTI [(match_operand: 1 "register_operand") (match_operand: 2 "register_operand")] - DOTPROD) - (match_operand:VCVTI 3 "register_operand")))] + DOTPROD)))] "TARGET_DOTPROD" -{ - emit_insn ( - gen_neon_dot (operands[3], operands[3], operands[1], - operands[2])); - emit_insn (gen_rtx_SET (operands[0], operands[3])); - DONE; -}) +) ;; Auto-vectorizer pattern for usdot (define_expand "usdot_prod" -- --BXVAT5kNtrzKuDFl Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="rb14661.patch" diff --git a/gcc/config/arm/neon.md b/gcc/config/arm/neon.md index 8b0a396947cc8e7345f178b926128d7224fb218a..876577fc20daee30ecdf03942c0d81c15bf8fe9a 100644 --- a/gcc/config/arm/neon.md +++ b/gcc/config/arm/neon.md @@ -2954,20 +2954,14 @@ (define_insn "neon_dot_lane" ;; and so the vectorizer provides r, in which the result has to be accumulated. (define_expand "dot_prod" [(set (match_operand:VCVTI 0 "register_operand") - (plus:VCVTI (unspec:VCVTI [(match_operand: 1 + (plus:VCVTI (match_operand:VCVTI 3 "register_operand") + (unspec:VCVTI [(match_operand: 1 "register_operand") (match_operand: 2 "register_operand")] - DOTPROD) - (match_operand:VCVTI 3 "register_operand")))] + DOTPROD)))] "TARGET_DOTPROD" -{ - emit_insn ( - gen_neon_dot (operands[3], operands[3], operands[1], - operands[2])); - emit_insn (gen_rtx_SET (operands[0], operands[3])); - DONE; -}) +) ;; Auto-vectorizer pattern for usdot (define_expand "usdot_prod" --BXVAT5kNtrzKuDFl--