From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 5BC773971C3F for ; Mon, 19 Jul 2021 23:10:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5BC773971C3F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 16JN9oLB025739; Mon, 19 Jul 2021 18:09:50 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 16JN9nnF025722; Mon, 19 Jul 2021 18:09:49 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Mon, 19 Jul 2021 18:09:42 -0500 From: Segher Boessenkool To: Bill Schmidt Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 14/55] rs6000: Parsing of overload input file Message-ID: <20210719230942.GT1583@gate.crashing.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, TXREP, T_SPF_HELO_PERMERROR, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2021 23:10:53 -0000 On Thu, Jun 17, 2021 at 10:18:58AM -0500, Bill Schmidt wrote: > * config/rs6000/rs6000-gen-builtins.c (ovld_stanza): New struct. > (MAXOVLDSTANZAS): New macro. > (ovld_stanzas): New variable. > (curr_ovld_stanza): Likewise. > (MAXOVLDS): New macro. > (ovlddata): New struct. > (ovlds): New variable. > (curr_ovld): Likewise. > (max_ovld_args): Likewise. > (parse_ovld_entry): New function. > (parse_ovld_stanza): Likewise. > (parse_ovld): Implement. > + /* Check for an optional overload id. Usually we use the builtin > + function id for that purpose, but sometimes we need multiple > + overload entries for the same builtin id, and it needs to be unique. */ > + consume_whitespace (); > + if (linebuf[pos] != '\n') > + { > + id = match_identifier (); > + ovlds[curr_ovld].ovld_id_name = id; > + consume_whitespace (); > + } So everything is just strings here, so you do not have any real problem with conflicting IDs. Okay. This is fine for trunk as well. Thanks! Segher