From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 30A56384800A for ; Tue, 20 Jul 2021 23:41:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 30A56384800A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 16KNeRL6007126; Tue, 20 Jul 2021 18:40:27 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 16KNeR5m007125; Tue, 20 Jul 2021 18:40:27 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Tue, 20 Jul 2021 18:40:26 -0500 From: Segher Boessenkool To: Bill Schmidt Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 17/55] rs6000: Write output to the builtins header file Message-ID: <20210720234026.GD1583@gate.crashing.org> References: <07dd852cc22dabe081dfa55d16343664be440ace.1623941441.git.wschmidt@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <07dd852cc22dabe081dfa55d16343664be440ace.1623941441.git.wschmidt@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, TXREP, T_SPF_HELO_PERMERROR, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2021 23:41:29 -0000 On Thu, Jun 17, 2021 at 10:19:01AM -0500, Bill Schmidt wrote: > 2021-06-07 Bill Schmidt > > gcc/ > * config/rs6000/rs6000-gen-builtins.c > (write_autogenerated_header): New function. > (write_decls): Likewise. > (write_extern_fntype): New callback function. > (write_header_file): Implement. > + /* #### Cannot mark this as a GC root because only pointer types can > + be marked as GTY((user)) and be GC roots. All trees in here are > + kept alive by other globals, so not a big deal. Alternatively, > + we could change the enum fields to ints and cast them in and out > + to avoid requiring a GTY((user)) designation, but that seems > + unnecessarily gross. */ Quite :-) Maybe you want to print that as a comment to the generated file as well? It makes more sense there. Okay for trunk. Thanks! Segher