From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 3BDA8384802E for ; Tue, 20 Jul 2021 23:52:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3BDA8384802E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 16KNpur7007826; Tue, 20 Jul 2021 18:51:56 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 16KNptop007823; Tue, 20 Jul 2021 18:51:55 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Tue, 20 Jul 2021 18:51:55 -0500 From: Segher Boessenkool To: Bill Schmidt Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 18/55] rs6000: Write output to the builtins init file, part 1 of 3 Message-ID: <20210720235155.GE1583@gate.crashing.org> References: <9b7092a69c5849d5b4911c01054481fdc7a0e099.1623941441.git.wschmidt@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9b7092a69c5849d5b4911c01054481fdc7a0e099.1623941441.git.wschmidt@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, KAM_NUMSUBJECT, TXREP, T_SPF_HELO_PERMERROR, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2021 23:52:58 -0000 On Thu, Jun 17, 2021 at 10:19:02AM -0500, Bill Schmidt wrote: > 2021-06-07 Bill Schmidt > > gcc/ > * config/rs6000/rs6000-gen-builtins.c (write_fntype): New > callback function. > (write_fntype_init): New stub function. > (write_init_bif_table): Likewise. > (write_init_ovld_table): New function. > (write_init_file): Implement. > + /* Check whether we have a "tf" token in this string, representing > + a float128_type_node. It's possible that float128_type_node is > + undefined (occurs for -maltivec -mno-vsx, for example), so we > + must guard against that. */ Yeah, this is still a problem :-( > + /* Similarly, look for decimal float tokens. */ > + int dfp_found = (strstr (ovlds[i].fndecl, "dd") != NULL > + || strstr (ovlds[i].fndecl, "td") != NULL > + || strstr (ovlds[i].fndecl, "sd") != NULL); Strange ordering? It's not alphabetic, it's not by size -- is it random? > + /* The fndecl for an overload is arbitrarily the first one > + for the overload. We sort out the real types when > + processing the overload in the gcc front end. */ Same as before -- please put such comments in the generated file! Okay for trunk. Thanks! Segher