From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 802493857424 for ; Wed, 21 Jul 2021 18:59:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 802493857424 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 16LIwUB2005034; Wed, 21 Jul 2021 13:58:30 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 16LIwUIq005029; Wed, 21 Jul 2021 13:58:30 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Wed, 21 Jul 2021 13:58:30 -0500 From: Segher Boessenkool To: Bill Schmidt Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 23/55] rs6000: Incorporate new builtins code into the build machinery Message-ID: <20210721185830.GK1583@gate.crashing.org> References: <4f27468885fd84aba5f0dc2369a284f3cffa2b34.1623941441.git.wschmidt@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f27468885fd84aba5f0dc2369a284f3cffa2b34.1623941441.git.wschmidt@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, TXREP, T_SPF_HELO_PERMERROR, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jul 2021 18:59:38 -0000 On Thu, Jun 17, 2021 at 10:19:07AM -0500, Bill Schmidt wrote: > 2021-06-07 Bill Schmidt > > gcc/ > * config.gcc (extra_objs): Include rs6000-builtins.o and > rs6000-c.o. The rs6000-c.o part needs an explanation, and probably should be a separate (bugfix) patch (and it needs backports?) The changelog entry should read * config.gcc (powerpc*-*-*): Include [...] in extra_objs. or similar. > * config/rs6000/t-rs6000 (rs6000-gen-builtins.o): New target. > (rbtree.o): Likewise. > (rs6000-gen-builtins): Likewise. > (rs6000-builtins.c): Likewise. > (rs6000-builtins.h): Likewise. > (rs6000.o): Add dependency. > (EXTRA_HEADERS): Add rs6000-vecdefines.h. > (rs6000-vecdefines.h): New target. > (rs6000-builtins.o): Likewise. > (rs6000-call.o): Add rs6000-builtins.h as a dependency. > (rs6000-c.o): Likewise. > +rs6000-gen-builtins.o: $(srcdir)/config/rs6000/rs6000-gen-builtins.c > + $(COMPILE) $(CXXFLAGS) $< > + $(POSTCOMPILE) > + > +rbtree.o: $(srcdir)/config/rs6000/rbtree.c > + $(COMPILE) $< > + $(POSTCOMPILE) Why does one need CXXFLAGS and the other does not? > +# TODO: Whenever GNU make 4.3 is the minimum required, we should use > +# grouped targets on this: That may be quite a while still. GNU make is the foundation of everything, so we cannot require very new versions of it ever. In the meantime, you can make all these targets depend on an intermediate target (that you mark with .INTERMEDIATE), and have that intermediate target have the dependencies. This is from version 3.74.3 and we require 3.80 already, so this is fine. > +EXTRA_HEADERS += rs6000-vecdefines.h > +rs6000-vecdefines.h : rs6000-builtins.c No space before the colon please. Segher