From: Segher Boessenkool <segher@kernel.crashing.org>
To: HAO CHEN GUI <guihaoc@linux.ibm.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Bill Schmidt <wschmidt@linux.ibm.com>
Subject: Re: [PATCH, rs6000] fix execution failure of parity_1.f90 on P10 [PR100952]
Date: Wed, 21 Jul 2021 17:19:54 -0500 [thread overview]
Message-ID: <20210721221954.GL1583@gate.crashing.org> (raw)
In-Reply-To: <7e58772f-4cec-f025-75dd-dca153e038a3@linux.ibm.com>
Sorry for the delay!
On Tue, Jul 13, 2021 at 09:38:33AM +0800, HAO CHEN GUI wrote:
> PR target/100952
> * config/rs6000/rs6000.md (cstore<mode>4): Fix wrong fall through.
> diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md
> index 3f59b544f6a..d7c13d4e79d 100644
> --- a/gcc/config/rs6000/rs6000.md
> +++ b/gcc/config/rs6000/rs6000.md
> @@ -11623,7 +11623,10 @@ (define_expand "cstore<mode>4"
> {
> /* Everything is best done with setbc[r] if available. */
> if (TARGET_POWER10 && TARGET_ISEL)
> - rs6000_emit_int_cmove (operands[0], operands[1], const1_rtx, const0_rtx);
> + {
> + rs6000_emit_int_cmove (operands[0], operands[1], const1_rtx, const0_rtx);
> + DONE;
> + }
>
> /* Expanding EQ and NE directly to some machine instructions does not help
> but does hurt combine. So don't. */
Perfect. Okay for trunk and backports (but do not touch GCC 11 right
now without RM approval, see
<https://gcc.gnu.org/pipermail/gcc/2021-July/236837.html>). Thanks!
Segher
prev parent reply other threads:[~2021-07-21 22:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 3:01 HAO CHEN GUI
2021-07-13 1:38 ` HAO CHEN GUI
2021-07-19 2:39 ` Ping " HAO CHEN GUI
2021-07-21 22:19 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721221954.GL1583@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=guihaoc@linux.ibm.com \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).