From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Martin Liška" <mliska@suse.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] rs6000: Fix restored rs6000_long_double_type_size.
Date: Fri, 23 Jul 2021 12:57:59 -0500 [thread overview]
Message-ID: <20210723175759.GP1583@gate.crashing.org> (raw)
In-Reply-To: <cdd6af83-49fc-1054-647e-ccabeafd4efa@suse.cz>
Hi!
On Fri, Jul 23, 2021 at 07:47:54AM +0200, Martin Liška wrote:
> On 7/12/21 7:20 PM, Segher Boessenkool wrote:
> >>>>+static __attribute__ ((optimize ("-fno-stack-protector"))) __typeof
> >>>>(f) *
> >>>
> >>>-fno-stack-protector is default.
> >>
> >>Yes, but one needs an optimize attribute in order to trigger
> >>cl_target_option_save/restore
> >>mechanism.
> >
> >So it behaves differently if you select the default than if you do not
> >select anything? That is wrong, no?
>
> Sorry, I don't get your example, please explain it.
If -mbork is the default, the coompiler whould behave the same if you
invoke it with -mbork as when you do not. And the optimize attribute
should work exactly the same as command line options.
Or perhaps you are saying you have this in the testcase only to exercise
the option save/restore code paths? Please document that then, in the
testcase.
Segher
next prev parent reply other threads:[~2021-07-23 17:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 13:22 Martin Liška
2021-06-23 22:46 ` Segher Boessenkool
2021-06-28 12:19 ` Martin Liška
2021-07-12 4:19 ` Martin Liška
2021-07-12 17:00 ` Segher Boessenkool
2021-07-12 17:20 ` Segher Boessenkool
2021-07-23 5:45 ` Martin Liska
2021-07-23 5:45 ` Martin Liska
2021-07-23 5:45 ` Martin Liska
2021-07-23 5:47 ` Martin Liška
2021-07-23 17:57 ` Segher Boessenkool [this message]
2021-08-05 12:05 ` Martin Liška
2021-08-05 15:39 ` Segher Boessenkool
2021-08-05 16:49 ` Martin Liška
2021-08-05 20:06 ` Segher Boessenkool
[not found] ` <202107230545.16N5jkeY006982@gate.crashing.org>
2021-07-23 18:00 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723175759.GP1583@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).