From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 012943847822 for ; Tue, 27 Jul 2021 15:05:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 012943847822 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-VnQWsmquPDSu0oaxt7OoOQ-1; Tue, 27 Jul 2021 11:05:08 -0400 X-MC-Unique: VnQWsmquPDSu0oaxt7OoOQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7E3DD875047 for ; Tue, 27 Jul 2021 15:05:07 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-143.ams2.redhat.com [10.36.112.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1595760854; Tue, 27 Jul 2021 15:05:06 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 16RF54364178741 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 27 Jul 2021 17:05:04 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 16RF53Gb4178740; Tue, 27 Jul 2021 17:05:03 +0200 Date: Tue, 27 Jul 2021 17:05:03 +0200 From: Jakub Jelinek To: Ulrich Drepper Cc: gcc-patches@gcc.gnu.org Subject: Re: OpenMP 5.1: omp_display_env Message-ID: <20210727150503.GK2380545@tucnak> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jul 2021 15:05:11 -0000 On Tue, Jul 27, 2021 at 04:26:22PM +0200, Ulrich Drepper via Gcc-patches wrote: > I know OpenMP 5.1 is not really a focus yet but adding this new interface > should not be problematic. I stumbled across this part of the spec and the > functionality is really already mostly there in the form of > OMP_DISPLAY_ENV=verbose etc. This is just a function interface to the same > functionality. > > Aside from the busywork to add a new interface (headers, map file) the only > real question was how to deal with the two parameters which are passed > to handle_omp_display_env in the current implementation. The > omp_display_env interface is supposed to show the information of the > initial values and therefore I think the right implementation is to store > the values determined in the constructor in two global, static variables > and reuse them. > > The rest should be completely boring and therefore not distracting anyone > from OpenMP 5.0 work. Thanks. You'll need to write a ChangeLog entry and put it at the end of the commit message, otherwise pre-commit hooks will reject the commit. --- a/libgomp/env.c +++ b/libgomp/env.c @@ -1210,46 +1213,11 @@ parse_gomp_openacc_dim (void) } } -static void -handle_omp_display_env (unsigned long stacksize, int wait_policy) +void +omp_display_env (int verbose) Please add ialias (omp_display_env) right after the function definition, we don't want to introduce new PLT slots unnecessarily and omp_display_env is an exported function. > --- a/libgomp/fortran.c > +++ b/libgomp/fortran.c And ialias_redirect (omp_display_env) here. > @@ -736,3 +736,9 @@ omp_get_default_allocator_ () > { > return (intptr_t) omp_get_default_allocator (); > } > + > +void > +omp_display_env_ (const int32_t *verbose) > +{ > + omp_display_env (*verbose); > +} For Fortran functions/subroutines that take integer arguments libgomp typically defines two functions, one with _ suffix and one with _8_ suffix, the former taking const int32_t * and the latter const int64_t * and using !! for logicals and TO_INT macro for integers. Please grep e.g. for omp_set_dynamic in fortran.c, libgomp.map and omp_lib.f90.in. This is needed to make calls to those functions work even with -fdefault-integer-8 > --- a/libgomp/omp_lib.f90.in > +++ b/libgomp/omp_lib.f90.in > @@ -653,6 +653,12 @@ > end function > end interface > > + interface > + subroutine omp_display_env (verbose) > + logical,intent(in) :: verbose > + end subroutine > + end interface See above. Plus, please add space between comma and intent(in). Otherwise LGTM. Jakub