From: "Paul A. Clarke" <pc@us.ibm.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: Bill Schmidt <wschmidt@linux.ibm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
segher@kernel.crashing.org
Subject: Re: [PATCH v3 1/2] rs6000: Add support for _mm_minpos_epu16
Date: Thu, 29 Jul 2021 17:03:18 -0500 [thread overview]
Message-ID: <20210729220318.GA41937@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> (raw)
In-Reply-To: <CAGWvnynsiTtLGrS0-jfg6jQkWpe3eYQH1vghMCNAgF6Lvxv=Kg@mail.gmail.com>
On Tue, Jul 27, 2021 at 10:29:13PM -0400, David Edelsohn via Gcc-patches wrote:
> > Add a naive implementation of the subject x86 intrinsic to
> > ease porting.
> >
> > 2021-07-15 Paul A. Clarke <pc@us.ibm.com>
> >
> > gcc
> > * config/rs6000/smmintrin.h (_mm_minpos_epu16): New.
>
> Segher already approved this with the changes requested.
Segher said:
| This does not compute the index correctly for big endian (it needs to
| walk from right to left for that). The construction of the return value
| looks wrong as well.
|
| Okay for trunk with that fixed. Thanks!
I responded:
| I'm not seeing the issue here. The values are numbered by element order,
| and the results are in the "first" (minimum value) and "second" (index of
| first encountered minimum value in element order) elements of the result.
I did not get a response, nor did I change any code. It feels like a stretch
to equate the above exchange to "approved", so I'll continue to wait for
explicit approval.
PC
next prev parent reply other threads:[~2021-07-29 22:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 2:29 David Edelsohn
2021-07-29 22:03 ` Paul A. Clarke [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-07-15 23:29 [PATCH v3 0/2] " Paul A. Clarke
2021-07-15 23:29 ` [PATCH v3 1/2] " Paul A. Clarke
2021-07-16 20:06 ` Bill Schmidt
2021-08-02 22:29 ` Segher Boessenkool
2021-08-03 13:01 ` Paul A. Clarke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210729220318.GA41937@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com \
--to=pc@us.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).