From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id E71283865474 for ; Fri, 30 Jul 2021 22:13:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E71283865474 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16UM4Bo1088371; Fri, 30 Jul 2021 18:13:44 -0400 Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com with ESMTP id 3a4sn20je0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jul 2021 18:13:44 -0400 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 16UMCRMS003212; Fri, 30 Jul 2021 22:13:43 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma04wdc.us.ibm.com with ESMTP id 3a235s23cr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jul 2021 22:13:43 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 16UMDhEu30343554 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Jul 2021 22:13:43 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 03BB212405B; Fri, 30 Jul 2021 22:13:43 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AAB4E124055; Fri, 30 Jul 2021 22:13:42 +0000 (GMT) Received: from li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com (unknown [9.160.174.47]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTPS; Fri, 30 Jul 2021 22:13:42 +0000 (GMT) Date: Fri, 30 Jul 2021 17:13:40 -0500 From: "Paul A. Clarke" To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH v2 4/6] rs6000: Add tests for SSE4.1 "ceil" intrinsics Message-ID: <20210730221340.GC41937@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> References: <20210716135022.489455-1-pc@us.ibm.com> <20210716135022.489455-5-pc@us.ibm.com> <20210728221632.GC1583@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210728221632.GC1583@gate.crashing.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: sc9JtTNBdO8DPeQ4jAfRajb79t1GCiKZ X-Proofpoint-GUID: sc9JtTNBdO8DPeQ4jAfRajb79t1GCiKZ X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-30_11:2021-07-30, 2021-07-30 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 mlxscore=0 spamscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 impostorscore=0 suspectscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2107300150 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jul 2021 22:13:47 -0000 On Wed, Jul 28, 2021 at 05:16:32PM -0500, Segher Boessenkool wrote: > On Fri, Jul 16, 2021 at 08:50:20AM -0500, Paul A. Clarke wrote: > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/powerpc/sse4_1-round.h > > @@ -0,0 +1,27 @@ > > +#include > > +#include > > +#include "sse4_1-check.h" > > + > > +#define DIM(a) (sizeof (a) / sizeof ((a)[0])) > > Pet peeve: sizeof is an operator, not a function, so even if you want to > protect the macro parameter this just is > #define DIM(a) (sizeof (a) / sizeof (a)[0]) > > > + (void) fesetround (round_save); > > Please don't cast to (void). That never does *anything*. > > Okay for trunk (these are all testsuite files after all, and we should > test horrrible style as well! :-P ) I didn't want to be responsible for promulgating horrible style, so I incorporated the above changes and pushed as d656a3d3ce88d402a14e8c120f1b0e78a3979deb. :-) PC