From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <segher@kernel.crashing.org>
Received: from gate.crashing.org (gate.crashing.org [63.228.1.57])
 by sourceware.org (Postfix) with ESMTP id BDBEF3858015
 for <gcc-patches@gcc.gnu.org>; Wed,  4 Aug 2021 00:35:20 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BDBEF3858015
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none)
 header.from=kernel.crashing.org
Authentication-Results: sourceware.org;
 spf=fail smtp.mailfrom=kernel.crashing.org
Received: from gate.crashing.org (localhost.localdomain [127.0.0.1])
 by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 1740YKhT016971;
 Tue, 3 Aug 2021 19:34:20 -0500
Received: (from segher@localhost)
 by gate.crashing.org (8.14.1/8.14.1/Submit) id 1740YJ4k016970;
 Tue, 3 Aug 2021 19:34:19 -0500
X-Authentication-Warning: gate.crashing.org: segher set sender to
 segher@kernel.crashing.org using -f
Date: Tue, 3 Aug 2021 19:34:18 -0500
From: Segher Boessenkool <segher@kernel.crashing.org>
To: will schmidt <will_schmidt@vnet.ibm.com>
Cc: Bill Schmidt <wschmidt@linux.ibm.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 47/55] rs6000: Builtin expansion, part 4
Message-ID: <20210804003418.GY1583@gate.crashing.org>
References: <cover.1623941441.git.wschmidt@linux.ibm.com>
 <1f28ba77c244256484e000eab60d041181612ff4.1623941442.git.wschmidt@linux.ibm.com>
 <3b98c985191f7d3d0be8ab19e6580887991c4d74.camel@vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3b98c985191f7d3d0be8ab19e6580887991c4d74.camel@vnet.ibm.com>
User-Agent: Mutt/1.4.2.3i
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, KAM_NUMSUBJECT, TXREP, T_SPF_HELO_PERMERROR,
 T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Aug 2021 00:35:21 -0000

Whoops, I forgot some stuff:

On Tue, Jul 27, 2021 at 04:06:49PM -0500, will schmidt wrote:
> On Thu, 2021-06-17 at 10:19 -0500, Bill Schmidt via Gcc-patches wrote:
> >  static rtx
> >  ldv_expand_builtin (rtx target, insn_code icode, rtx *op, machine_mode tmode)
> >  {
> > +  rtx pat, addr;
> > +  bool blk = (icode == CODE_FOR_altivec_lvlx
> > +	      || icode == CODE_FOR_altivec_lvlxl
> > +	      || icode == CODE_FOR_altivec_lvrx
> > +	      || icode == CODE_FOR_altivec_lvrxl);
> > +
> > +  if (target == 0
> > +      || GET_MODE (target) != tmode
> > +      || ! (*insn_data[icode].operand[0].predicate) (target, tmode))
> 
> No space after "!" ?  (here and later on 'pat'.).

It can be written as just
      || !insn_data[icode].operand[0].predicate (target, tmode))
even.  The * is completely optional, and you don't need the extra parens
without it.


Segher