From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <segher@kernel.crashing.org>
Received: from gate.crashing.org (gate.crashing.org [63.228.1.57])
 by sourceware.org (Postfix) with ESMTP id 25B5D383F427
 for <gcc-patches@gcc.gnu.org>; Wed,  4 Aug 2021 00:50:57 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 25B5D383F427
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none)
 header.from=kernel.crashing.org
Authentication-Results: sourceware.org;
 spf=fail smtp.mailfrom=kernel.crashing.org
Received: from gate.crashing.org (localhost.localdomain [127.0.0.1])
 by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 1740nu8S017925;
 Tue, 3 Aug 2021 19:49:56 -0500
Received: (from segher@localhost)
 by gate.crashing.org (8.14.1/8.14.1/Submit) id 1740ntwH017924;
 Tue, 3 Aug 2021 19:49:55 -0500
X-Authentication-Warning: gate.crashing.org: segher set sender to
 segher@kernel.crashing.org using -f
Date: Tue, 3 Aug 2021 19:49:55 -0500
From: Segher Boessenkool <segher@kernel.crashing.org>
To: will schmidt <will_schmidt@vnet.ibm.com>
Cc: Bill Schmidt <wschmidt@linux.ibm.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 52/55] rs6000: Debug support
Message-ID: <20210804004955.GA1583@gate.crashing.org>
References: <cover.1623941441.git.wschmidt@linux.ibm.com>
 <45258f83249345b1faf49554a6f4a7940983f822.1623941442.git.wschmidt@linux.ibm.com>
 <fa946ae1e98406eb1e3e2e0144992d90338df447.camel@vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fa946ae1e98406eb1e3e2e0144992d90338df447.camel@vnet.ibm.com>
User-Agent: Mutt/1.4.2.3i
X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, TXREP, T_SPF_HELO_PERMERROR,
 T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Aug 2021 00:50:58 -0000

On Tue, Jul 27, 2021 at 04:07:22PM -0500, will schmidt wrote:
> On Thu, 2021-06-17 at 10:19 -0500, Bill Schmidt via Gcc-patches wrote:
> > +  else if (type == bool_V16QI_type_node)
> > +    return "vbc";
> > +  else if (type == bool_V2DI_type_node)
> > +    return "vbll";
> > +  else if (type == bool_V4SI_type_node)
> > +    return "vbi";
> > +  else if (type == bool_V8HI_type_node)
> > +    return "vbs";
> 
> I'd be strongly tempted to rearrange the order and put V16 after V8 in
> the list.  Similar to the order you previously used in
> rs6000_expand_new_builtin().     Same comment elsewhere.

These are ordered on return value.  It is hard to make some order of all
these disparate things based on the actual type, but the strings is a
neat way out ;-)

(A comment "ordered by return value" would be good to have).

> > +  /*
> >    if (TARGET_DEBUG_BUILTIN)
> >      fprintf (stderr, "rs6000_builtin, code = %4d, %s%s\n",
> >  	     (int)code, name, attr_string);
> > +  */
> 
> Could probably just drop that chunk, instead of commenting it out. 

Or fix up its spacing :-P

> > +      for (int i = 1; i < (int) RS6000_BIF_MAX; i++)

That is an good reason to *not* have the max as enum value, btw: you
need a cast to use it.  Make the max a macro, and then it can include
all casting you need right in there :-)


Segher