From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 19CA33839425 for ; Mon, 16 Aug 2021 07:10:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 19CA33839425 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-331-4SEXlFukPEWK_-ATFPTC9w-1; Mon, 16 Aug 2021 03:10:44 -0400 X-MC-Unique: 4SEXlFukPEWK_-ATFPTC9w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D7E46107ACF5; Mon, 16 Aug 2021 07:10:42 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 74A01189BB; Mon, 16 Aug 2021 07:10:42 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 17G7Ab6C824983 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 16 Aug 2021 09:10:38 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 17G7AZbM824980; Mon, 16 Aug 2021 09:10:35 +0200 Date: Mon, 16 Aug 2021 09:10:34 +0200 From: Jakub Jelinek To: liuhongt Cc: gcc-patches@gcc.gnu.org, jakub@rehat.com Subject: Re: [PATCH] [i386] Optimize __builtin_shuffle_vector. Message-ID: <20210816071034.GS2380545@tucnak> Reply-To: Jakub Jelinek References: <20210813084753.GG2380545@tucnak> <20210816051838.868413-1-hongtao.liu@intel.com> MIME-Version: 1.0 In-Reply-To: <20210816051838.868413-1-hongtao.liu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Aug 2021 07:10:47 -0000 On Mon, Aug 16, 2021 at 01:18:38PM +0800, liuhongt via Gcc-patches wrote: > + /* Accept VNxHImode and VNxQImode now. */ > + if (!TARGET_AVX512VL && GET_MODE_SIZE (mode) < 64) > + return false; > + > + /* vpermw. */ > + if (!TARGET_AVX512BW && inner_size == 2) > + return false; > + > + /* vpermb. */ Too many spaces after dot. > @@ -18301,7 +18380,7 @@ expand_vec_perm_1 (struct expand_vec_perm_d *d) > if (expand_vec_perm_palignr (d, true)) > return true; > > - /* Try the AVX512F vperm{s,d} instructions. */ > + /* Try the AVX512F vperm{w,b,s,d} and instructions */ What is the " and" doing there? > + /* Check that the permutation is suitable for pmovz{bw,wd,dq}. > + For example V16HImode to V8HImode > + { 0 2 4 6 8 10 12 14 * * * * * * * * }. */ > + for (int i = 0; i != nelt/2; i++) nelt / 2 please Otherwise LGTM. Jakub