From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id AC3B4385780B for ; Mon, 23 Aug 2021 21:41:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AC3B4385780B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 17NLeWtY013238; Mon, 23 Aug 2021 16:40:32 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 17NLeWJE013227; Mon, 23 Aug 2021 16:40:32 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Mon, 23 Aug 2021 16:40:31 -0500 From: Segher Boessenkool To: Bill Schmidt Cc: gcc-patches@gcc.gnu.org, dje.gcc@gmail.com, willschm@linux.ibm.com Subject: Re: [PATCH 08/34] rs6000: Add Power9 builtins Message-ID: <20210823214031.GB1583@gate.crashing.org> References: <252069d30b9f13a5e77d40fe4aee660715f00395.1627562851.git.wschmidt@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <252069d30b9f13a5e77d40fe4aee660715f00395.1627562851.git.wschmidt@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, TXREP, T_SPF_HELO_PERMERROR, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Aug 2021 21:41:36 -0000 On Thu, Jul 29, 2021 at 08:30:55AM -0500, Bill Schmidt wrote: > 2021-06-15 Bill Schmidt > * config/rs6000/rs6000-builtin-new.def: Add power9-vector, power9, > and power9-64 stanzas. > +; These things need some review to see whether they really require > +; MASK_POWERPC64. For xsxexpdp, this seems to be fine for 32-bit, > +; because the result will always fit in 32 bits and the return > +; value is SImode; but the pattern currently requires TARGET_64BIT. That is wrong then? It should never have TARGET_64BIT if it isn't addressing memory (or the like). Did you just typo this? > +; On the other hand, xsxsigdp has a result that doesn't fit in > +; 32 bits, and the return value is DImode, so it seems that > +; TARGET_64BIT (actually TARGET_POWERPC64) is justified. TBD. #### Because xsxsigdp needs it, it makes sense to have it for xsxexpdp as well, or we would get a weird holey API. Okay for trunk (with the typo fixed if it is one). Thanks! Segher