* [PATCH] Fix arm target build with inhibit_libc
@ 2021-08-30 12:01 Sebastian Huber
2021-09-01 5:09 ` Sebastian Huber
0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Huber @ 2021-08-30 12:01 UTC (permalink / raw)
To: gcc-patches
Do not declare abort in "libgcc/unwind-arm-common.inc" since it is already
provided by "tsystem.h". It fixes the following build error:
In file included from libgcc/config/arm/unwind-arm.c:144:
libgcc/unwind-arm-common.inc:55:24: error: macro "abort" passed 1 arguments, but takes just 0
55 | extern void abort (void);
libgcc/
* unwind-arm-common.inc (abort): Remove.
---
libgcc/unwind-arm-common.inc | 4 ----
1 file changed, 4 deletions(-)
diff --git a/libgcc/unwind-arm-common.inc b/libgcc/unwind-arm-common.inc
index c9b70c10d4f5..77ec02ec811e 100644
--- a/libgcc/unwind-arm-common.inc
+++ b/libgcc/unwind-arm-common.inc
@@ -50,10 +50,6 @@
#define ARM_SIGCONTEXT_R0 0xc
#endif
-/* We add a prototype for abort here to avoid creating a dependency on
- target headers. */
-extern void abort (void);
-
/* Definitions for C++ runtime support routines. We make these weak
declarations to avoid pulling in libsupc++ unnecessarily. */
typedef unsigned char bool;
--
2.26.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix arm target build with inhibit_libc
2021-08-30 12:01 [PATCH] Fix arm target build with inhibit_libc Sebastian Huber
@ 2021-09-01 5:09 ` Sebastian Huber
2021-09-01 7:00 ` Christophe Lyon
0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Huber @ 2021-09-01 5:09 UTC (permalink / raw)
To: gcc-patches
On 30/08/2021 14:01, Sebastian Huber wrote:
> Do not declare abort in "libgcc/unwind-arm-common.inc" since it is already
> provided by "tsystem.h". It fixes the following build error:
>
> In file included from libgcc/config/arm/unwind-arm.c:144:
> libgcc/unwind-arm-common.inc:55:24: error: macro "abort" passed 1 arguments, but takes just 0
> 55 | extern void abort (void);
>
> libgcc/
>
> * unwind-arm-common.inc (abort): Remove.
Could someone please have a look at this patch. Currently, the arm build
with inhibit_libc is broken.
--
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax: +49-89-18 94 741 - 08
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix arm target build with inhibit_libc
2021-09-01 5:09 ` Sebastian Huber
@ 2021-09-01 7:00 ` Christophe Lyon
2021-09-01 15:48 ` Jeff Law
0 siblings, 1 reply; 4+ messages in thread
From: Christophe Lyon @ 2021-09-01 7:00 UTC (permalink / raw)
To: Sebastian Huber; +Cc: GCC Patches
On Wed, Sep 1, 2021 at 7:09 AM Sebastian Huber <
sebastian.huber@embedded-brains.de> wrote:
> On 30/08/2021 14:01, Sebastian Huber wrote:
> > Do not declare abort in "libgcc/unwind-arm-common.inc" since it is
> already
> > provided by "tsystem.h". It fixes the following build error:
> >
> > In file included from libgcc/config/arm/unwind-arm.c:144:
> > libgcc/unwind-arm-common.inc:55:24: error: macro "abort" passed 1
> arguments, but takes just 0
> > 55 | extern void abort (void);
> >
> > libgcc/
> >
> > * unwind-arm-common.inc (abort): Remove.
>
> Could someone please have a look at this patch. Currently, the arm build
> with inhibit_libc is broken.
>
>
I'm OK with it since it looks like what I proposed a couple of days ago :-)
But I'm not a maintainer.
Thanks,
Christophe
> --
> embedded brains GmbH
> Herr Sebastian HUBER
> Dornierstr. 4
> 82178 Puchheim
> Germany
> email: sebastian.huber@embedded-brains.de
> phone: +49-89-18 94 741 - 16
> fax: +49-89-18 94 741 - 08
>
> Registergericht: Amtsgericht München
> Registernummer: HRB 157899
> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
> Unsere Datenschutzerklärung finden Sie hier:
> https://embedded-brains.de/datenschutzerklaerung/
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix arm target build with inhibit_libc
2021-09-01 7:00 ` Christophe Lyon
@ 2021-09-01 15:48 ` Jeff Law
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Law @ 2021-09-01 15:48 UTC (permalink / raw)
To: Christophe Lyon, Sebastian Huber; +Cc: GCC Patches
On 9/1/2021 1:00 AM, Christophe Lyon via Gcc-patches wrote:
> On Wed, Sep 1, 2021 at 7:09 AM Sebastian Huber <
> sebastian.huber@embedded-brains.de> wrote:
>
>> On 30/08/2021 14:01, Sebastian Huber wrote:
>>> Do not declare abort in "libgcc/unwind-arm-common.inc" since it is
>> already
>>> provided by "tsystem.h". It fixes the following build error:
>>>
>>> In file included from libgcc/config/arm/unwind-arm.c:144:
>>> libgcc/unwind-arm-common.inc:55:24: error: macro "abort" passed 1
>> arguments, but takes just 0
>>> 55 | extern void abort (void);
>>>
>>> libgcc/
>>>
>>> * unwind-arm-common.inc (abort): Remove.
>> Could someone please have a look at this patch. Currently, the arm build
>> with inhibit_libc is broken.
OK. Or just wrap it with #ifndef abort if removing it causes other
problems.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-01 15:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-30 12:01 [PATCH] Fix arm target build with inhibit_libc Sebastian Huber
2021-09-01 5:09 ` Sebastian Huber
2021-09-01 7:00 ` Christophe Lyon
2021-09-01 15:48 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).