From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 7578F3858417 for ; Mon, 30 Aug 2021 13:49:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7578F3858417 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-58-2vrEFkn2PFOVPUx2tNKsAg-1; Mon, 30 Aug 2021 09:49:48 -0400 X-MC-Unique: 2vrEFkn2PFOVPUx2tNKsAg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9D2548799EC; Mon, 30 Aug 2021 13:49:47 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 604EA5D9F4; Mon, 30 Aug 2021 13:49:43 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 17UDneZJ1033694 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 30 Aug 2021 15:49:40 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 17UDnduq1033693; Mon, 30 Aug 2021 15:49:39 +0200 Date: Mon, 30 Aug 2021 15:49:39 +0200 From: Jakub Jelinek To: "H.J. Lu" Cc: gcc-patches@gcc.gnu.org, Uros Bizjak , Marek Polacek Subject: Re: [PATCH v2] x86-64: Add ABI warning for 64-bit vectors Message-ID: <20210830134939.GN920497@tucnak> Reply-To: Jakub Jelinek References: <20210829191123.100740-1-hjl.tools@gmail.com> MIME-Version: 1.0 In-Reply-To: <20210829191123.100740-1-hjl.tools@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2021 13:49:54 -0000 On Sun, Aug 29, 2021 at 12:11:23PM -0700, H.J. Lu wrote: > --- a/gcc/config/i386/i386.c > +++ b/gcc/config/i386/i386.c > @@ -1840,6 +1840,54 @@ init_cumulative_args (CUMULATIVE_ARGS *cum, /* Argument info to initialize */ > cfun->machine->arg_reg_available = (cum->nregs > 0); > } > > +/* Return the single 64-bit vector type of TYPE. */ > + > +static const_tree > +single_m64_base_type (const_tree type) > +{ > + if ((TREE_CODE (type) == RECORD_TYPE > + || TREE_CODE (type) == UNION_TYPE > + || TREE_CODE (type) == QUAL_UNION_TYPE) > + && int_size_in_bytes (type) == 8) > + { > + const_tree field; > + const_tree first_field = nullptr; > + > + for (field = TYPE_FIELDS (type); > + field; > + field = DECL_CHAIN (field)) > + if (TREE_CODE (field) == FIELD_DECL) > + { > + if (TREE_TYPE (field) == error_mark_node) > + continue; > + > + /* Skip if structure has more than one field. */ > + if (first_field) > + return nullptr; > + > + first_field = field; > + } > + > + /* Skip if structure doesn't have any fields. */ > + if (!first_field) > + return nullptr; Is this an attempt to emulate compute_record_mode or something else? How should it treat zero-width bitfields (either the C ones kept in the structures or C++ ones formerly removed from them and now no longer)? compute_record_mode actually has more complicated details... Jakub