From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 37934385841D for ; Wed, 1 Sep 2021 09:49:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 37934385841D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-134-N9JOd1kqOTGGptaW0osoxQ-1; Wed, 01 Sep 2021 05:49:28 -0400 X-MC-Unique: N9JOd1kqOTGGptaW0osoxQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 775A4501E6; Wed, 1 Sep 2021 09:49:19 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E8C1B5C1BB; Wed, 1 Sep 2021 09:49:18 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 1819nG9a3756664 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 1 Sep 2021 11:49:16 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 1819nEM13756663; Wed, 1 Sep 2021 11:49:14 +0200 Date: Wed, 1 Sep 2021 11:49:14 +0200 From: Jakub Jelinek To: Thomas Schwinge Cc: gcc-patches@gcc.gnu.org Subject: Re: Simplify 'gcc/tree.c:walk_tree_1' handling of 'OMP_CLAUSE' (was: Fix PR 25886. Convert OMP_CLAUSE_* into sub-codes.) Message-ID: <20210901094914.GF920497@tucnak> Reply-To: Jakub Jelinek References: <43D7B83A.3060802@redhat.com> <87tuj55ty3.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 In-Reply-To: <87tuj55ty3.fsf@euler.schwinge.homeip.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Sep 2021 09:49:32 -0000 On Tue, Aug 31, 2021 at 08:51:16PM +0200, Thomas Schwinge wrote: > gcc/ > * tree.c (walk_tree_1) : Simplify. : And you don't mention the omp_clause_num_ops and build_omp_clause comment changes in the ChangeLog. Otherwise LGTM, thanks. Jakub