From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id DD571385840D for ; Sat, 4 Sep 2021 21:54:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DD571385840D Received: by mail-pg1-x52e.google.com with SMTP id q68so2683897pga.9 for ; Sat, 04 Sep 2021 14:54:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Kj6uTTo52qpCo91O7Ah5KCt2ebfmL68/0OkAtl1yIhQ=; b=QzQFDWPWpx3y8g9zl19i2y6uhrOborUKSIQfi4SIZjr+jFc5/T0p2mbcKRTypfVE6M 0jz+zIpnEXw4G0EF3UFgOpM1I7teUd20PtL5PFBrRaIV9vXN+5g3fikhTvGeAQOmrSN0 tYCV1N6BIM8DqwaOlqcSdwWCAqo76a9QGt6HwanC7Ye4Yy64YwMBvf3+A3VuYVxwDaUR QTlKBP6WOB9P6xVFGQvkvEZAKdcSqaKV9OtHLnK8oK/OZS6vTaHwalexddRTfg1HHeJX q6L96CayIhydFivpEC7ghZLpXrqDPCQpkQVOS39WOMLUgpmKiItsPL0npFF+UE81OKyV NQ8g== X-Gm-Message-State: AOAM531W6ggZBuHWyUqQx2arsqZNq72EYvDerTNgp3Lqlw4YbxMTsFKW pdDrFs/hSU9Rj8j4CO8wotftYDIu+cg= X-Google-Smtp-Source: ABdhPJy0WsMr06K7DtDAahd9bOA+PmEmcVj/rYec9h5FoNlD6l5iwtss3eqCI4uZP2hNSNMn3dirCw== X-Received: by 2002:a63:7d0f:: with SMTP id y15mr5037986pgc.446.1630792445732; Sat, 04 Sep 2021 14:54:05 -0700 (PDT) Received: from gnu-cfl-2.localdomain ([172.56.39.243]) by smtp.gmail.com with ESMTPSA id a78sm3228652pfa.95.2021.09.04.14.54.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Sep 2021 14:54:05 -0700 (PDT) Received: from gnu-cfl-2.. (localhost [IPv6:::1]) by gnu-cfl-2.localdomain (Postfix) with ESMTP id 26EA0C0062; Sat, 4 Sep 2021 14:54:04 -0700 (PDT) From: "H.J. Lu" To: gcc-patches@gcc.gnu.org Cc: liuhongt , Uros Bizjak Subject: [PATCH] x86: Add non-destructive source to @xorsign3_1 Date: Sat, 4 Sep 2021 14:54:04 -0700 Message-Id: <20210904215404.166845-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3032.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Sep 2021 21:54:08 -0000 Add non-destructive source alternative to @xorsign3_1 for AVX. gcc/ PR target/89984 * config/i386/i386-expand.c (ix86_split_xorsign): Use operands[2]. * config/i386/i386.md (@xorsign3_1): Add non-destructive source alternative for AVX. gcc/testsuite/ PR target/89984 * gcc.target/i386/pr89984-1.c: New test. * gcc.target/i386/pr89984-2.c: Likewise. * gcc.target/i386/xorsign-avx.c: Likewise. --- gcc/config/i386/i386-expand.c | 13 ++++++++----- gcc/config/i386/i386.md | 11 ++++++----- gcc/testsuite/gcc.target/i386/pr89984-1.c | 8 ++++++++ gcc/testsuite/gcc.target/i386/pr89984-2.c | 10 ++++++++++ gcc/testsuite/gcc.target/i386/xorsign-avx.c | 4 ++++ 5 files changed, 36 insertions(+), 10 deletions(-) create mode 100644 gcc/testsuite/gcc.target/i386/pr89984-1.c create mode 100644 gcc/testsuite/gcc.target/i386/pr89984-2.c create mode 100644 gcc/testsuite/gcc.target/i386/xorsign-avx.c diff --git a/gcc/config/i386/i386-expand.c b/gcc/config/i386/i386-expand.c index 2500dbfa7fb..273a0ba8e3d 100644 --- a/gcc/config/i386/i386-expand.c +++ b/gcc/config/i386/i386-expand.c @@ -2279,21 +2279,24 @@ void ix86_split_xorsign (rtx operands[]) { machine_mode mode, vmode; - rtx dest, op0, mask, x; + rtx dest, op0, op1, mask, x; dest = operands[0]; op0 = operands[1]; + op1 = operands[2]; mask = operands[3]; mode = GET_MODE (dest); vmode = GET_MODE (mask); - dest = lowpart_subreg (vmode, dest, mode); - x = gen_rtx_AND (vmode, dest, mask); - emit_insn (gen_rtx_SET (dest, x)); + op1 = lowpart_subreg (vmode, op1, mode); + x = gen_rtx_AND (vmode, op1, mask); + emit_insn (gen_rtx_SET (op1, x)); op0 = lowpart_subreg (vmode, op0, mode); - x = gen_rtx_XOR (vmode, dest, op0); + x = gen_rtx_XOR (vmode, op1, op0); + + dest = lowpart_subreg (vmode, dest, mode); emit_insn (gen_rtx_SET (dest, x)); } diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md index 0cd151ce4e5..18b91c77937 100644 --- a/gcc/config/i386/i386.md +++ b/gcc/config/i386/i386.md @@ -10806,17 +10806,18 @@ (define_expand "xorsign3" "ix86_expand_xorsign (operands); DONE;") (define_insn_and_split "@xorsign3_1" - [(set (match_operand:MODEF 0 "register_operand" "=Yv") + [(set (match_operand:MODEF 0 "register_operand" "=Yv,Yv") (unspec:MODEF - [(match_operand:MODEF 1 "register_operand" "Yv") - (match_operand:MODEF 2 "register_operand" "0") - (match_operand: 3 "nonimmediate_operand" "Yvm")] + [(match_operand:MODEF 1 "register_operand" "Yv,Yv") + (match_operand:MODEF 2 "register_operand" "0,Yv") + (match_operand: 3 "nonimmediate_operand" "Yvm,Yvm")] UNSPEC_XORSIGN))] "SSE_FLOAT_MODE_P (mode) && TARGET_SSE_MATH" "#" "&& reload_completed" [(const_int 0)] - "ix86_split_xorsign (operands); DONE;") + "ix86_split_xorsign (operands); DONE;" + [(set_attr "isa" "noavx,avx")]) ;; One complement instructions diff --git a/gcc/testsuite/gcc.target/i386/pr89984-1.c b/gcc/testsuite/gcc.target/i386/pr89984-1.c new file mode 100644 index 00000000000..d77691c0da0 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr89984-1.c @@ -0,0 +1,8 @@ +/* { dg-do compile { target { ! ia32 } } } */ +/* { dg-options "-O2 -mno-avx -msse2" } */ + +float +check_f_pos (float x, float y) +{ + return x * __builtin_copysignf (1.0f, y); +} diff --git a/gcc/testsuite/gcc.target/i386/pr89984-2.c b/gcc/testsuite/gcc.target/i386/pr89984-2.c new file mode 100644 index 00000000000..ff6a8e50573 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr89984-2.c @@ -0,0 +1,10 @@ +/* { dg-do compile { target { ! ia32 } } } */ +/* { dg-options "-O2 -mavx" } */ + +float +check_f_pos (float x, float y) +{ + return x * __builtin_copysignf (1.0f, y); +} + +/* { dg-final { scan-assembler-not "vmovaps" } } */ diff --git a/gcc/testsuite/gcc.target/i386/xorsign-avx.c b/gcc/testsuite/gcc.target/i386/xorsign-avx.c new file mode 100644 index 00000000000..f2e2054b6fb --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/xorsign-avx.c @@ -0,0 +1,4 @@ +/* { dg-do run { target avx_runtime } } */ +/* { dg-options "-O2 -mavx -mfpmath=sse -ftree-vectorize" } */ + +#include "xorsign.c" -- 2.31.1