From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 35B883857C73 for ; Mon, 6 Sep 2021 11:01:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 35B883857C73 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-493-xqQAk9kAOnCV1ow4SxOhZA-1; Mon, 06 Sep 2021 07:01:49 -0400 X-MC-Unique: xqQAk9kAOnCV1ow4SxOhZA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C367B1854E20; Mon, 6 Sep 2021 11:01:48 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 568166091B; Mon, 6 Sep 2021 11:01:48 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 186B1kM73013221 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 6 Sep 2021 13:01:46 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 186B1fsM3013220; Mon, 6 Sep 2021 13:01:41 +0200 Date: Mon, 6 Sep 2021 13:01:41 +0200 From: Jakub Jelinek To: Hongtao Liu Cc: Richard Biener , liuhongt , GCC Patches Subject: Re: [PATCH] Enable auto-vectorization at O2 with very-cheap cost model. Message-ID: <20210906110141.GS920497@tucnak> Reply-To: Jakub Jelinek References: <20210906084614.7974-1-hongtao.liu@intel.com> <20210906094127.GQ920497@tucnak> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Sep 2021 11:01:53 -0000 On Mon, Sep 06, 2021 at 06:58:37PM +0800, Hongtao Liu wrote: > > process_options would mean it affects only the command line and not > > __attribute__((optimize ("O2", "ftree-vectorize"))) > > etc. > > So, shouldn't it be instead done in default_options_optimization, somewhere > It seems default_options_optimization is before read_comline_options > which means it can't handle cmdline option -O2 -ftree-vectorize. > > default_options_optimization (opts, opts_set, > decoded_options, decoded_options_count, > loc, lang_mask, &handlers, dc); > > read_cmdline_options (opts, opts_set, > decoded_options, decoded_options_count, > loc, lang_mask, > &handlers, dc); So what about finish_options then? default_options_optimization has only a single caller that then calls read_cmdline_options and then finish_options. Jakub